You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/09 06:28:19 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #8279: feat: Added log format support in syslog plugin.

spacewander commented on code in PR #8279:
URL: https://github.com/apache/apisix/pull/8279#discussion_r1017476138


##########
t/plugin/syslog.t:
##########
@@ -132,8 +132,36 @@ passed
 [error]
 
 
+=== TEST 5: add plugin metadata

Review Comment:
   Could you check the logged data format?
   You can refer to https://github.com/apache/apisix/pull/7328/files#diff-1108dce1e7823ca0b746c4ba69e692e4b02c6d49117d70859954b56cbb810c29 as an example.
   
   BTW, new test should be added at the end.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org