You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/04 14:06:33 UTC

Review Request 38121: Add Python Support for QuiesceOffers

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add Python Support for QuiesceOffers


Diffs
-----

  src/python/interface/src/mesos/interface/__init__.py 686abb24d88765d7ec7cab5b76b57299339b7b00 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 

Diff: https://reviews.apache.org/r/38121/diff/


Testing
-------


Thanks,

Guangya Liu


Re: Review Request 38121: Add Python Support for QuiesceOffers

Posted by Guangya Liu <gy...@gmail.com>.

> On 九月 15, 2015, 7:14 p.m., Vinod Kone wrote:
> > Update the python test framework to send this call.

I see that the reviveOffers also do not have a test and I want to handle those two APIs in another patch, make sense? Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/#review99073
-----------------------------------------------------------


On 九月 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38121/
> -----------------------------------------------------------
> 
> (Updated 九月 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add Python Support for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   src/python/interface/src/mesos/interface/__init__.py 686abb24d88765d7ec7cab5b76b57299339b7b00 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 
> 
> Diff: https://reviews.apache.org/r/38121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 38121: Add Python Support for QuiesceOffers

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/#review99073
-----------------------------------------------------------


Update the python test framework to send this call.


src/python/interface/src/mesos/interface/__init__.py (lines 235 - 236)
<https://reviews.apache.org/r/38121/#comment155905>

    ditto. Use the same wording as you did in scheduler.hpp.


- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38121/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add Python Support for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   src/python/interface/src/mesos/interface/__init__.py 686abb24d88765d7ec7cab5b76b57299339b7b00 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 
> 
> Diff: https://reviews.apache.org/r/38121/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Re: Review Request 38121: Add Python Support for QuiesceOffers

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/
-----------------------------------------------------------

(Updated 九月 18, 2015, 3:56 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add Python Support for QuiesceOffers


Diffs (updated)
-----

  src/python/interface/src/mesos/interface/__init__.py 686abb24d88765d7ec7cab5b76b57299339b7b00 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 

Diff: https://reviews.apache.org/r/38121/diff/


Testing
-------


Thanks,

Guangya Liu


Re: Review Request 38121: Add Python Support for QuiesceOffers

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38121/
-----------------------------------------------------------

(Updated 九月 16, 2015, 5:49 a.m.)


Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.


Bugs: MESOS-3037
    https://issues.apache.org/jira/browse/MESOS-3037


Repository: mesos


Description
-------

Add Python Support for QuiesceOffers


Diffs (updated)
-----

  src/python/interface/src/mesos/interface/__init__.py 686abb24d88765d7ec7cab5b76b57299339b7b00 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp b1ad8e529806a047480e8d7affe4e7ecdc7d9725 
  src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 609dfa3735f19eea2242dfb82ed3a4af3a0b8b9b 

Diff: https://reviews.apache.org/r/38121/diff/


Testing
-------


Thanks,

Guangya Liu