[jira] [Resolved] (GEODE-5732) TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag

["Dan Smith (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Smith resolved GEODE-5732.
------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0

> TxCommitMessageTest doesn't actually test for presence/absence of shadow key flag
> ---------------------------------------------------------------------------------
>
>                 Key: GEODE-5732
>                 URL: https://issues.apache.org/jira/browse/GEODE-5732
>             Project: Geode
>          Issue Type: Bug
>          Components: transactions
>            Reporter: Bill
>            Assignee: Bill
>            Priority: Major
>              Labels: pull-request-available, swat
>             Fix For: 1.8.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The various toDataXX and fromDataXX methods purport to test serialization/deserialization of TXCommitMessage between different product versions. Primarily, this entails looking for presence/absence of the shadow key boolean. Unfortunately, since the move to Mockito, only 1/7 of the tests actually fail when we break the product.
> The fix is to not use mocking for these tests, and to instead serialize/deserialize to/from buffers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)