You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/25 18:40:10 UTC

[GitHub] [tvm] areusch opened a new pull request #7337: Introduce code_loader to AutoTVM.

areusch opened a new pull request #7337:
URL: https://github.com/apache/tvm/pull/7337


    * Prepares for autotuning with microTVM, and provides extension hook
      for VTA.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7337: Introduce module_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7337:
URL: https://github.com/apache/tvm/pull/7337#issuecomment-784609070


   @comaniac great point! I've updated code_loader to module_loader everywhere in this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch edited a comment on pull request #7337: Introduce code_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
areusch edited a comment on pull request #7337:
URL: https://github.com/apache/tvm/pull/7337#issuecomment-783589544


   @tmoreau89 @tqchen @jroesch  @junrushao1994 @comaniac @masahi @tkonolige 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7337: Introduce code_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7337:
URL: https://github.com/apache/tvm/pull/7337#issuecomment-767028495


   @tmoreau89 do you have suggestions where to move the VTA hook? we can leave in default, but given we are introducing this hook it seems like a better idea to leave the default code loader as simple as possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #7337: Introduce code_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #7337:
URL: https://github.com/apache/tvm/pull/7337#discussion_r580717702



##########
File path: python/tvm/autotvm/measure/measure_methods.py
##########
@@ -473,15 +486,21 @@ def __call__(self, measure_input, tmp_dir, **kwargs):
         return BuildResult(filename, arg_info, None, time.time() - tic)
 
 
+CodeLoader = typing.Callable[
+    [dict, dict], typing.ContextManager[typing.Tuple[tvm.rpc.RPCSession, tvm.runtime.Module]]
+]
+
+
 def run_through_rpc(
     measure_input,
     build_result,
     number,
     repeat,
     min_repeat_ms,
     cooldown_interval,
-    remote_args,
+    remote_kw,

Review comment:
       Better to use full name `remote_kwargs`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7337: Introduce code_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7337:
URL: https://github.com/apache/tvm/pull/7337#issuecomment-767028495


   @tmoreau89 do you have suggestions where to move the VTA hook? we can leave in default, but given we are introducing this hook it seems like a better idea to leave the default code loader as simple as possible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tmoreau89 merged pull request #7337: Introduce module_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7337:
URL: https://github.com/apache/tvm/pull/7337


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on a change in pull request #7337: Introduce module_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #7337:
URL: https://github.com/apache/tvm/pull/7337#discussion_r581471390



##########
File path: python/tvm/autotvm/measure/measure_methods.py
##########
@@ -473,15 +486,21 @@ def __call__(self, measure_input, tmp_dir, **kwargs):
         return BuildResult(filename, arg_info, None, time.time() - tic)
 
 
+CodeLoader = typing.Callable[
+    [dict, dict], typing.ContextManager[typing.Tuple[tvm.rpc.RPCSession, tvm.runtime.Module]]
+]
+
+
 def run_through_rpc(
     measure_input,
     build_result,
     number,
     repeat,
     min_repeat_ms,
     cooldown_interval,
-    remote_args,
+    remote_kw,

Review comment:
       also a good point, done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #7337: Introduce code_loader to AutoTVM.

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7337:
URL: https://github.com/apache/tvm/pull/7337#issuecomment-783589544


   @tmoreau89 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org