You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/07/27 09:03:07 UTC
[PR] fix(server-ng): legacy-parity consumer group errors, roster HTTP bind [iggy]
hubcio opened a new pull request, #3754:
URL: https://github.com/apache/iggy/pull/3754
Consumer group join/leave on the ng metadata plane committed
silent OK no-ops when the stream, topic, group or membership was
missing, so clients saw success where the legacy server reports
an error. Both ops now resolve level by level and commit the
legacy codes (1009/2010/5000, and 5006 for leaving as an absent
member), pinned end to end by an integration test across TCP,
QUIC and WebSocket. Consumer group ids become 0-based to match
the legacy server; server-ng has no stable-format users yet.
The HTTP listener bound from the top-level [http].address even
in cluster mode, so one-host clusters collided on the shared
port. It now binds from the node's cluster roster port with the
same fallback as ws/quic, and the roster reports the port
actually bound, letting every node run from byte-identical
per-node configs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server-ng): legacy-parity consumer group errors, roster HTTP bind [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #3754:
URL: https://github.com/apache/iggy/pull/3754#discussion_r3657593398
##########
core/server-ng/src/bootstrap.rs:
##########
@@ -2112,31 +2117,52 @@ fn resolve_optional_listener_addr(
Ok(None)
}
+/// Client-facing listener addresses resolved for this cluster node. Each port
+/// comes from the node's roster entry, falling back to the top-level listener
+/// default when the roster leaves it unset.
+struct ClusterClientAddrs {
+ client: SocketAddr,
+ ws: Option<SocketAddr>,
+ quic: Option<SocketAddr>,
+ http: Option<SocketAddr>,
+}
+
fn resolve_cluster_client_addrs(
self_node: &configs::ng_cluster::ClusterNodeConfig,
default_client_addr: SocketAddr,
default_ws_addr: Option<SocketAddr>,
default_quic_addr: Option<SocketAddr>,
-) -> Result<(SocketAddr, Option<SocketAddr>, Option<SocketAddr>), ServerNgError> {
+ default_http_addr: Option<SocketAddr>,
+) -> Result<ClusterClientAddrs, ServerNgError> {
let client_port = self_node
.ports
.tcp
.unwrap_or_else(|| default_client_addr.port());
- let client_listen_addr =
- socket_addr_from_parts("cluster.nodes[*].ports.tcp", &self_node.ip, client_port)?;
- let ws_listen_addr = resolve_cluster_optional_addr(
+ let client = socket_addr_from_parts("cluster.nodes[*].ports.tcp", &self_node.ip, client_port)?;
+ let ws = resolve_cluster_optional_addr(
self_node,
"cluster.nodes[*].ports.websocket",
default_ws_addr,
|ports| ports.websocket,
)?;
- let quic_listen_addr = resolve_cluster_optional_addr(
+ let quic = resolve_cluster_optional_addr(
self_node,
"cluster.nodes[*].ports.quic",
default_quic_addr,
|ports| ports.quic,
)?;
- Ok((client_listen_addr, ws_listen_addr, quic_listen_addr))
+ let http = resolve_cluster_optional_addr(
+ self_node,
+ "cluster.nodes[*].ports.http",
+ default_http_addr,
+ |ports| ports.http,
+ )?;
Review Comment:
good catch,cluster now binds config-address ip + roster port; ports mandatory (fallback removed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server-ng): legacy-parity consumer group errors, roster HTTP bind [iggy]
Posted by "numinnex (via GitHub)" <gi...@apache.org>.
numinnex merged PR #3754:
URL: https://github.com/apache/iggy/pull/3754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server-ng): legacy-parity consumer group errors, roster HTTP bind [iggy]
Posted by "krishvishal (via GitHub)" <gi...@apache.org>.
krishvishal commented on code in PR #3754:
URL: https://github.com/apache/iggy/pull/3754#discussion_r3657024444
##########
core/server-ng/src/bootstrap.rs:
##########
@@ -2112,31 +2117,52 @@ fn resolve_optional_listener_addr(
Ok(None)
}
+/// Client-facing listener addresses resolved for this cluster node. Each port
+/// comes from the node's roster entry, falling back to the top-level listener
+/// default when the roster leaves it unset.
+struct ClusterClientAddrs {
+ client: SocketAddr,
+ ws: Option<SocketAddr>,
+ quic: Option<SocketAddr>,
+ http: Option<SocketAddr>,
+}
+
fn resolve_cluster_client_addrs(
self_node: &configs::ng_cluster::ClusterNodeConfig,
default_client_addr: SocketAddr,
default_ws_addr: Option<SocketAddr>,
default_quic_addr: Option<SocketAddr>,
-) -> Result<(SocketAddr, Option<SocketAddr>, Option<SocketAddr>), ServerNgError> {
+ default_http_addr: Option<SocketAddr>,
+) -> Result<ClusterClientAddrs, ServerNgError> {
let client_port = self_node
.ports
.tcp
.unwrap_or_else(|| default_client_addr.port());
- let client_listen_addr =
- socket_addr_from_parts("cluster.nodes[*].ports.tcp", &self_node.ip, client_port)?;
- let ws_listen_addr = resolve_cluster_optional_addr(
+ let client = socket_addr_from_parts("cluster.nodes[*].ports.tcp", &self_node.ip, client_port)?;
+ let ws = resolve_cluster_optional_addr(
self_node,
"cluster.nodes[*].ports.websocket",
default_ws_addr,
|ports| ports.websocket,
)?;
- let quic_listen_addr = resolve_cluster_optional_addr(
+ let quic = resolve_cluster_optional_addr(
self_node,
"cluster.nodes[*].ports.quic",
default_quic_addr,
|ports| ports.quic,
)?;
- Ok((client_listen_addr, ws_listen_addr, quic_listen_addr))
+ let http = resolve_cluster_optional_addr(
+ self_node,
+ "cluster.nodes[*].ports.http",
+ default_http_addr,
+ |ports| ports.http,
+ )?;
Review Comment:
Cluster mode discards the host from `[http].address`.
`bootstrap.rs:2154-2159` -> `resolve_cluster_optional_addr:2168-2179` takes only
`default_addr.port()`, then `socket_addr_from_parts:3014-3027` =
`SocketAddr::new(self_node.ip, port)`. Operator host dropped, not merged.
- `config.toml:41` = `127.0.0.1:3000`, documented `:40` "listens on localhost
only"; example node `ip = "192.168.1.100"` (`:644`). So `cluster.enabled = true`
silently moves JWT minting and `/ui` from loopback to the cluster interface.
No log, no warning.
- `Dockerfile:58`, `helm/.../values.yaml:95`, `web/docker-compose.yml:24` all
`0.0.0.0:3000` (helm `README.md:209` requires it). Those narrow to the roster
IP, breaking loopback probes and sidecar scrapes.
- Validation misses both: `cluster.rs:257-276` guards `if let Some(port)`, so
unset ports resolving to one shared endpoint are never compared.
`TransportPorts.http` (`cluster.rs:160`) undocumented.
Fix: `SocketAddr::new(default_http_addr.ip(), roster_port_or_default)`. If
ws/quic symmetry is preferred, log the effective bind when it differs from
`http.address` and document it on `TransportPorts` + `[cluster]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(server-ng): legacy-parity consumer group errors, roster HTTP bind [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3754:
URL: https://github.com/apache/iggy/pull/3754#issuecomment-5089593007
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3754?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.89%. Comparing base ([`c5fec1f`](https://app.codecov.io/gh/apache/iggy/commit/c5fec1ff646e7513619c771cea909188526a7141?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5642ed0`](https://app.codecov.io/gh/apache/iggy/commit/5642ed03258fdef20bade26562e1b94139cd72bd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3754 +/- ##
============================================
- Coverage 74.54% 73.89% -0.65%
Complexity 969 969
============================================
Files 1306 1304 -2
Lines 150028 149733 -295
Branches 125462 125324 -138
============================================
- Hits 111840 110649 -1191
- Misses 34686 35581 +895
- Partials 3502 3503 +1
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.86% <ø> (+0.02%)` | :arrow_up: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.71% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.28% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.27% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.52% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.77% <ø> (-11.48%)` | :arrow_down: |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3754/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.08% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3754?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/metadata/src/stm/consumer\_group.rs](https://app.codecov.io/gh/apache/iggy/pull/3754?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fconsumer_group.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL2NvbnN1bWVyX2dyb3VwLnJz) | `59.03% <ø> (+1.09%)` | :arrow_up: |
| [core/metadata/src/stm/result.rs](https://app.codecov.io/gh/apache/iggy/pull/3754?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fresult.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3Jlc3VsdC5ycw==) | `92.30% <ø> (-0.04%)` | :arrow_down: |
| [core/metadata/src/stm/snapshot.rs](https://app.codecov.io/gh/apache/iggy/pull/3754?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fsnapshot.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3NuYXBzaG90LnJz) | `86.25% <ø> (-0.06%)` | :arrow_down: |
| [core/metadata/src/stm/stream.rs](https://app.codecov.io/gh/apache/iggy/pull/3754?src=pr&el=tree&filepath=core%2Fmetadata%2Fsrc%2Fstm%2Fstream.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9tZXRhZGF0YS9zcmMvc3RtL3N0cmVhbS5ycw==) | `60.34% <ø> (+0.48%)` | :arrow_up: |
| [core/server-ng/src/bootstrap.rs](https://app.codecov.io/gh/apache/iggy/pull/3754?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fbootstrap.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL2Jvb3RzdHJhcC5ycw==) | `11.81% <ø> (+0.09%)` | :arrow_up: |
| [core/server-ng/src/partition\_reconciler.rs](https://app.codecov.io/gh/apache/iggy/pull/3754?src=pr&el=tree&filepath=core%2Fserver-ng%2Fsrc%2Fpartition_reconciler.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZXJ2ZXItbmcvc3JjL3BhcnRpdGlvbl9yZWNvbmNpbGVyLnJz) | `86.20% <ø> (-0.12%)` | :arrow_down: |
... and [59 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3754/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org