You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Romain Manni-Bucau (Created) (JIRA)" <ji...@apache.org> on 2012/04/18 12:04:36 UTC
[jira] [Created] (CXF-4246) replace asm:asm by a shaded jar
replace asm:asm by a shaded jar
-------------------------------
Key: CXF-4246
URL: https://issues.apache.org/jira/browse/CXF-4246
Project: CXF
Issue Type: Improvement
Reporter: Romain Manni-Bucau
Hi,
asm is used in cxf in several places.
asm lib is often shaded to be used in containers (spring, tomee, geronimo, ...)
the asm dependency can lead to dependencies issues.
It could be nice if CXF can use either a shaded version of asm (like org.apache.xbean:xbean-asm-shaded) or use reflection to try several provided implementations (asm, xbean-asm-shaded, spring-asm...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4246) replace asm:asm by a shaded jar
Posted by "Romain Manni-Bucau (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256408#comment-13256408 ]
Romain Manni-Bucau commented on CXF-4246:
-----------------------------------------
Note: i patched cxf-bundle to use xbean-asm in tomee: http://svn.apache.org/repos/asf/openejb/trunk/patched-libraries/cxf-bundle-patched/
> replace asm:asm by a shaded jar
> -------------------------------
>
> Key: CXF-4246
> URL: https://issues.apache.org/jira/browse/CXF-4246
> Project: CXF
> Issue Type: Improvement
> Reporter: Romain Manni-Bucau
>
> Hi,
> asm is used in cxf in several places.
> asm lib is often shaded to be used in containers (spring, tomee, geronimo, ...)
> the asm dependency can lead to dependencies issues.
> It could be nice if CXF can use either a shaded version of asm (like org.apache.xbean:xbean-asm-shaded) or use reflection to try several provided implementations (asm, xbean-asm-shaded, spring-asm...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CXF-4246) replace asm:asm by a shaded jar
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp reassigned CXF-4246:
--------------------------------
Assignee: Daniel Kulp
> replace asm:asm by a shaded jar
> -------------------------------
>
> Key: CXF-4246
> URL: https://issues.apache.org/jira/browse/CXF-4246
> Project: CXF
> Issue Type: Improvement
> Reporter: Romain Manni-Bucau
> Assignee: Daniel Kulp
>
> Hi,
> asm is used in cxf in several places.
> asm lib is often shaded to be used in containers (spring, tomee, geronimo, ...)
> the asm dependency can lead to dependencies issues.
> It could be nice if CXF can use either a shaded version of asm (like org.apache.xbean:xbean-asm-shaded) or use reflection to try several provided implementations (asm, xbean-asm-shaded, spring-asm...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CXF-4246) replace asm:asm by a shaded jar
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp updated CXF-4246:
-----------------------------
Affects Version/s: 2.3.10
2.4.7
2.5.3
2.6
Fix Version/s: 2.6.1
> replace asm:asm by a shaded jar
> -------------------------------
>
> Key: CXF-4246
> URL: https://issues.apache.org/jira/browse/CXF-4246
> Project: CXF
> Issue Type: Improvement
> Affects Versions: 2.3.10, 2.4.7, 2.5.3, 2.6
> Reporter: Romain Manni-Bucau
> Assignee: Daniel Kulp
> Fix For: 2.6.1
>
>
> Hi,
> asm is used in cxf in several places.
> asm lib is often shaded to be used in containers (spring, tomee, geronimo, ...)
> the asm dependency can lead to dependencies issues.
> It could be nice if CXF can use either a shaded version of asm (like org.apache.xbean:xbean-asm-shaded) or use reflection to try several provided implementations (asm, xbean-asm-shaded, spring-asm...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CXF-4246) replace asm:asm by a shaded jar
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp resolved CXF-4246.
------------------------------
Resolution: Fixed
This is now "fixed" in 2.6.1 (too large of a change to port back with all kinds of implications). Couple comments though:
1) CXF defaults to using the "real" asm and has been tested with 2.x, 3.x, and (new in 2.6.1) 4.x. Thus, no real need to shade any of those versions for CXF. We won't be shading in a version as I'd prefer to just use the real version provided by the asm project.
2) I'm "concerned" about the patched bundle you mentioned. At the March ASF board meeting, there was a discussion about this type of thing and the board members were quite appalled that an ASF project would even consider releasing code in another projects package namespaces, particularly without working with that project to resolve issues. Note that that will likely be NOT allowed in the future.
> replace asm:asm by a shaded jar
> -------------------------------
>
> Key: CXF-4246
> URL: https://issues.apache.org/jira/browse/CXF-4246
> Project: CXF
> Issue Type: Improvement
> Affects Versions: 2.3.10, 2.4.7, 2.5.3, 2.6
> Reporter: Romain Manni-Bucau
> Assignee: Daniel Kulp
> Fix For: 2.6.1
>
>
> Hi,
> asm is used in cxf in several places.
> asm lib is often shaded to be used in containers (spring, tomee, geronimo, ...)
> the asm dependency can lead to dependencies issues.
> It could be nice if CXF can use either a shaded version of asm (like org.apache.xbean:xbean-asm-shaded) or use reflection to try several provided implementations (asm, xbean-asm-shaded, spring-asm...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CXF-4246) replace asm:asm by a shaded jar
Posted by "Romain Manni-Bucau (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265378#comment-13265378 ]
Romain Manni-Bucau commented on CXF-4246:
-----------------------------------------
thank you the fix which is far enough for us.
+1 about the 2) (that's why i opened the issue).
> replace asm:asm by a shaded jar
> -------------------------------
>
> Key: CXF-4246
> URL: https://issues.apache.org/jira/browse/CXF-4246
> Project: CXF
> Issue Type: Improvement
> Affects Versions: 2.3.10, 2.4.7, 2.5.3, 2.6
> Reporter: Romain Manni-Bucau
> Assignee: Daniel Kulp
> Fix For: 2.6.1
>
>
> Hi,
> asm is used in cxf in several places.
> asm lib is often shaded to be used in containers (spring, tomee, geronimo, ...)
> the asm dependency can lead to dependencies issues.
> It could be nice if CXF can use either a shaded version of asm (like org.apache.xbean:xbean-asm-shaded) or use reflection to try several provided implementations (asm, xbean-asm-shaded, spring-asm...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira