You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Seth Wiesman (Jira)" <ji...@apache.org> on 2020/08/13 13:37:00 UTC
[jira] [Commented] (FLINK-18849) Improve the code tabs of the Flink
documents
[ https://issues.apache.org/jira/browse/FLINK-18849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177016#comment-17177016 ]
Seth Wiesman commented on FLINK-18849:
--------------------------------------
Fixed in master: 2c527fb9c8645b1da4a893577ad2eae3bbab179e
> Improve the code tabs of the Flink documents
> --------------------------------------------
>
> Key: FLINK-18849
> URL: https://issues.apache.org/jira/browse/FLINK-18849
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
> Reporter: Wei Zhong
> Assignee: Wei Zhong
> Priority: Minor
> Labels: pull-request-available
>
> Currently there are some minor problems on the code tabs of the Flink documents:
> # There are some tab labels like `data-lang="Java/Scala"`, which can not be changed synchronously with the label `data-lang="Java"` and `data-lang="Scala"`.
> # Case sensitive. If one code tab has a label `data-lang="java"` and another has the label `data-lang="Java"` in one page. They would not change synchronously.
> # Duplicated content. Many contents in the "Java" tab are the same as the "Scala" tab.
> I would like to improve the situation by following way:
> 1. When parsing the label like `data-lang="Java/Scala"`, we can clone the tab content, let one has the label `data-lang="Java"`, another has the label `data-lang="Scala"`.
> 2. Then force the first character of the data-lang value to be upper case. i.e. if the label is `data-lang="java"`, it will be modified to `data-lang="Java"`.
> 3. Add a new attribute "data-hide-tabs" to the "tabcontents" to hide the tab headers, so that we can let the text above the codes changes synchronously.
> 4. Add a new url parameter "code_tab" to set the default code tab to display when entering the page.
> This way we can remove the duplicated content via merge them into one element with a `data-lang="Java/Scala"` label. And all the tab can be changed synchronously when they are clicked.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)