You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/19 02:43:39 UTC

[GitHub] [echarts] pissang opened a new pull request #14289: fix(type): exporting more necessary types

pissang opened a new pull request #14289:
URL: https://github.com/apache/echarts/pull/14289


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   For some unknown reason, rewrited [vue-echarts#next](https://github.com/ecomfe/vue-echarts/tree/ee12ad9658f3745a6738c3df995fb0b328b35299) will have `Default export of the module has or is using private name` error when generating declarations. It only happens when exporting picked `ECharts#getDataURL`, `ECharts#getConnectedDataURL`, `ECharts#dispatchAction` methods to the vue component.
   
   So in this PR, we export these necessary private types to avoid this issue:
   
   + `echarts.Color`
   + `echarts.LinearGradientObject`
   + `echarts.RadialGradientObject`
   + `echarts.LinearGradientObject`
   + `echarts.SetOptionOpts`
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14289: fix(type): exporting more necessary types for generating declarations in the extensions

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14289:
URL: https://github.com/apache/echarts/pull/14289


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14289: fix(type): exporting more necessary types

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14289:
URL: https://github.com/apache/echarts/pull/14289#issuecomment-781774977


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14289: fix(type): exporting more necessary types for generating declarations in the extensions

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14289:
URL: https://github.com/apache/echarts/pull/14289#issuecomment-781862913


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org