[GitHub] [superset] villebro commented on a diff in pull request #23190: fix(dashboard): Focusing charts and native filters from filters badge

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #23190:
URL: https://github.com/apache/superset/pull/23190#discussion_r1117189228


##########
superset-frontend/src/dashboard/components/FiltersBadge/index.tsx:
##########
@@ -38,6 +37,7 @@ import {
   DashboardLayout,
   RootState,
 } from '../../types';
+import { setDirectPathToChild } from '../../actions/dashboardState';

Review Comment:
   pure subjective and personal preference, but double `..` always makes me cringe 😬 
   ```suggestion
   import { setDirectPathToChild } from 'src/dashboards/actions/dashboardState';
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org