You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/10/14 14:23:25 UTC

[GitHub] [cordova-common] breautek opened a new pull request, #180: ci: Remove Node 10/12 from matrix. Added Node 16 and 18.

breautek opened a new pull request, #180:
URL: https://github.com/apache/cordova-common/pull/180

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   CI
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Node 10/12 is now dated and EOL, therefore they have been removed from the matrix. Added Node 16 & 18 for modern test coverage.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   CI Matrix change
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   GH Actions will do it's thing.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-common] codecov-commenter commented on pull request #180: ci: Remove Node 10/12 from matrix. Added Node 16 and 18.

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #180:
URL: https://github.com/apache/cordova-common/pull/180#issuecomment-1279084670

   # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/180?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#180](https://codecov.io/gh/apache/cordova-common/pull/180?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b023bad) into [master](https://codecov.io/gh/apache/cordova-common/commit/4d8475dfd5e57265f87ff50420286a8ce88e3466?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d8475d) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #180   +/-   ##
   =======================================
     Coverage   87.79%   87.79%           
   =======================================
     Files          20       20           
     Lines        1131     1131           
   =======================================
     Hits          993      993           
     Misses        138      138           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-common] breautek merged pull request #180: ci: Remove Node 10/12 from matrix. Added Node 16 and 18.

Posted by GitBox <gi...@apache.org>.
breautek merged PR #180:
URL: https://github.com/apache/cordova-common/pull/180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org