You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/06/03 06:35:04 UTC
[GitHub] flink pull request #4068: [FLINK-6823] Activate checkstyle for runtime/broad...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4068
[FLINK-6823] Activate checkstyle for runtime/broadcast
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6823
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4068
----
commit 4d38968c9984f5d218fccb0864503960bf760665
Author: zentol <ch...@apache.org>
Date: 2017-06-02T20:18:49Z
[FLINK-6823] Activate checkstyle for runtime/broadcast
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4068: [FLINK-6823] Activate checkstyle for runtime/broad...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4068
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4068: [FLINK-6823] Activate checkstyle for runtime/broadcast
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4068
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4068: [FLINK-6823] Activate checkstyle for runtime/broad...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4068#discussion_r120427634
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableManager.java ---
@@ -18,34 +18,42 @@
package org.apache.flink.runtime.broadcast;
-import java.io.IOException;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-
import org.apache.flink.api.common.typeutils.TypeSerializerFactory;
import org.apache.flink.runtime.io.network.api.reader.MutableReader;
import org.apache.flink.runtime.operators.BatchTask;
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * The BroadcastVariableManager is used to manage the materialization of broadcast variables. References to materialized
+ * broadcast variables are cached and shared between parallel subtasks. A reference count is maintained to track whether
+ * a the materialization may be cleaned up.
+ */
public class BroadcastVariableManager {
-
+
private final ConcurrentHashMap<BroadcastVariableKey, BroadcastVariableMaterialization<?, ?>> variables =
new ConcurrentHashMap<BroadcastVariableKey, BroadcastVariableMaterialization<?, ?>>(16);
-
+
// --------------------------------------------------------------------------------------------
-
+
+ /**
+ * Materializes the broadcast variable for the given name, scoped to the given task and it's iteration superstep. An
--- End diff --
`it's` -> `its`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4068: [FLINK-6823] Activate checkstyle for runtime/broadcast
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4068
@greghogan fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4068: [FLINK-6823] Activate checkstyle for runtime/broadcast
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4068
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4068: [FLINK-6823] Activate checkstyle for runtime/broad...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/4068#discussion_r120427357
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/broadcast/BroadcastVariableManager.java ---
@@ -18,34 +18,42 @@
package org.apache.flink.runtime.broadcast;
-import java.io.IOException;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-
import org.apache.flink.api.common.typeutils.TypeSerializerFactory;
import org.apache.flink.runtime.io.network.api.reader.MutableReader;
import org.apache.flink.runtime.operators.BatchTask;
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * The BroadcastVariableManager is used to manage the materialization of broadcast variables. References to materialized
+ * broadcast variables are cached and shared between parallel subtasks. A reference count is maintained to track whether
+ * a the materialization may be cleaned up.
--- End diff --
Delete leading `a`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---