You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/07 23:56:55 UTC

[kudu-CR] Enable C++11

Hello Internal Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/1687

to look at the new patch set (#5).

Change subject: Enable C++11
......................................................................

Enable C++11

This is a rollup of changes necessary to move Kudu to C++11.
Component changes have been individually reviewed, as follows:

-----------------------------------------------------------------------

Enable Red Hat devtoolset in RHEL 6 Environments

We are moving to C++11 in the near future, and will require a C++11 compatible
compiler on all suported platforms. Since the RHEL 6 system compiler (GCC 4.4)
does not support C++11, we need an alternate. The Red Hat devtoolset provides a
toolchain with GCC 4.9. Libraries (such as libkudu_client.so) which are compiled
with the Red Hat devtoolset toolchain automatically statically link portions of
the standard library which are new for C++11. This will allow us to take
advantage of C++11 features in the client, but still remain compatible with
stock RHEL 6 systems.

This commit modifies the Jenkins build and test scripts to take advantage of the
devtoolset toolchain, hides the std library symbols that the devtoolset
links into library objects, and adds the devtoolset location to the default gcc
toolchain search paths for the thirdparty LLVM compiler. Additionally, since a
system compiler which supports C++11 can now be assumed, the precompiled clang
compiler is no longer a dependency on Linux and has been removed.

Change Id: I5505911044aa9fda8fb5010c6fe446c8f5c5616e

Build thirdparty clang with system compiler

We build LLVM 3.4.2 in thirdparty, but it requires a c++11 compiler to build.
Now that we require the system compiler to be c++11 compatible, we no longer
need the bootstrapping compiler.

Change Id: I4800d9eec0a566bcf71c59abdeae6a6d8b6cb40a
http://gerrit.cloudera.org:8080/1476

-----------------------------------------------------------------------

Enable C++11

Change Id: Ia9463b46428450e1a29c1684d47b46f96bf965cb
http://gerrit.cloudera.org:8080/#/c/1466

-----------------------------------------------------------------------

C++11: replace list_of with initializer lists

Change Id: I0d258e35a38be3a47854e51bd110dc07f05bdd3f
http://gerrit.cloudera.org:8080/#/c/1467

-----------------------------------------------------------------------

Replace boost::tuple with std::tuple

Change Id: Ia258a1833a4ae3509a3781717386324fdd63ef88
http://gerrit.cloudera.org:8080/#/c/1468

-----------------------------------------------------------------------

C++11: replace util::gtl::is_sorted with std::is_sorted

Change Id: Ifc51c4519c5c055aa62887fc6dcc1836572102f5
http://gerrit.cloudera.org:8080/#/c/1470

-----------------------------------------------------------------------

C++11: remove tr1

Change Id: I6c5559f9d14860fd568f86809377d94e5e1d3e6e
http://gerrit.cloudera.org:8080/#/c/1472

-----------------------------------------------------------------------

Add kudu::client::sp::shared_ptr as public shared pointer type

Change Id: I02d1c3691294f82498b9dfd25253cfca0b196dda
http://gerrit.cloudera.org:8080/#/c/1473

-----------------------------------------------------------------------

Replace gnu_cxx::hash with std::hash

gnu_cxx::hash is obsolete since c++11 introduced std::hash.

Change Id: Ic7e6af40cf8e6ca5069ad0185d4c136c4793fc31
http://gerrit.cloudera.org:8080/#/c/1477

-----------------------------------------------------------------------

Add OS X search paths when compiling with thirdparty clang

Change Id: I56051b321c9c9d3a1a521b4188e47961f64acd50
http://gerrit.cloudera.org:8080/#/c/1478

-----------------------------------------------------------------------

Replace boost::unique_lock with std::unique_lock

These particular uses of boost locks were failing to compile on Centos6 because
the system boost version is buggy when compiling with move semantics.

Change Id: I424077b29ac2ae10761df4afb12f554213c049be
http://gerrit.cloudera.org:8080/#/c/1479

-----------------------------------------------------------------------

Replace boost::shared_lock with kudu::shared_lock in WriteTransaction

The Boost shared_lock implementation distributed with Centos6 does not compile
with move semantics (specifically the operator= method). std::shared_lock is not
available till c++14.

Change Id: Icd42e3cb88f8c5e5d992d3f0d0324b6c9f81d915
http://gerrit.cloudera.org:8080/#/c/1480

-----------------------------------------------------------------------

Update mem tracker allocator for libc++ compatibility

The unordered_map type in libc++ is finicky about custom allocators.

Change Id: I8ca226abb2c7e3ca95c68533979e97dea4552b63
http://gerrit.cloudera.org:8080/#/c/1481

-----------------------------------------------------------------------

Update thirdparty llvm from 3.4 to 3.7

This updates our thirdparty LLVM version from 3.4 to 3.7. Major changes:

* ASAN and TSAN builds now use the thirdparty clang instead of the bootstrapping
  clang toolchain. The clang toolchain has been removed from the build process.
* Python 2.7 is now built in thirdparty on systems which have a different system
  Python version. Python 2.7 is a build dependency of LLVM 3.6+.
* Updated LLVM API calls in the codegen module.

Change Id: I9023dd138373bb580892877e437b9199b690bde3
http://gerrit.cloudera.org:8080/#/c/1572

-----------------------------------------------------------------------

Build instrumented thirdparty with libstdc++ in TSAN mode

The new c++11 toolchain is more sensitive to TSAN issues in the standard
library. This commit adds a TSAN instrumented libstdcxx 4.9.3 to the thirdparty
build when building with TSAN.

Change Id: I2157469910c38b6e1c750e431c564e7d2f7b7e58
http://gerrit.cloudera.org:8080/#/c/1657

-----------------------------------------------------------------------

Update YCM config for c++11

Change Id: I64b24b148d19fe3b0fa0acd655f081143118b191
http://gerrit.cloudera.org:8080/#/c/1658

-----------------------------------------------------------------------

Remove import of macos mach-o/loader.h from gutil/port.h

The llvm/Support/MachO.h header redefines constants as enum variants using the
same identifier as macro constants declared in the mach-o/loader.h system
header. This causes issues when macho-o/loader.h is included before the LLVM
header.

This commit removes the reliance on mach-o/loader.h in gutil/port.h by removing
some unused macros for working with attribute sections in binaries. The solution
is not perfect, since the system header may be necessary in the future, but hopefully
by then a fix will have landed in upstream LLVM
(https://llvm.org/bugs/show_bug.cgi?id=25871).

Change Id: Ib41ee2b53f39589d48622a12378a51e1a49c74bb
http://gerrit.cloudera.org:8080/#/c/1592

-----------------------------------------------------------------------

Change-Id: Ic52cbf98f583a3a953b1910e0017a8af448660d7
---
M .ycm_extra_conf.py
M CMakeLists.txt
M README.adoc
M build-support/enable_devtoolset.sh
M build-support/jenkins/build-and-test.sh
M build-support/lint.sh
M build-support/tsan-suppressions.txt
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.cc
M src/kudu/benchmarks/tpch/rpc_line_item_dao.h
M src/kudu/benchmarks/tpch/tpch-schemas.h
M src/kudu/benchmarks/tpch/tpch1.cc
M src/kudu/benchmarks/ycsb-schema.h
M src/kudu/cfile/binary_dict_block.h
M src/kudu/cfile/block_compression.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-dump.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/samples/CMakeLists.txt
M src/kudu/client/samples/sample.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
A src/kudu/client/shared_ptr.h
M src/kudu/client/symbols.map
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/codegen/CMakeLists.txt
M src/kudu/codegen/README
M src/kudu/codegen/code_generator.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/jit_wrapper.cc
M src/kudu/codegen/jit_wrapper.h
M src/kudu/codegen/module_builder.cc
M src/kudu/codegen/module_builder.h
M src/kudu/codegen/row_projector.cc
M src/kudu/codegen/row_projector.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/generic_iterators.cc
M src/kudu/common/generic_iterators.h
M src/kudu/common/key_encoder.cc
M src/kudu/common/partial_row-test.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/predicate-test.cc
M src/kudu/common/predicate_encoder-test.cc
M src/kudu/common/row.h
M src/kudu/common/row_changelist-test.cc
M src/kudu/common/row_key-util-test.cc
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/types.cc
M src/kudu/common/wire_protocol-test-util.h
M src/kudu/common/wire_protocol-test.cc
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus.cc
M src/kudu/consensus/consensus.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_peers.h
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/leader_election.h
M src/kudu/consensus/local_consensus.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/log_util.h
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/peer_manager.h
M src/kudu/consensus/raft_consensus-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/consensus/raft_consensus_state-test.cc
M src/kudu/consensus/raft_consensus_state.cc
M src/kudu/consensus/raft_consensus_state.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager.h
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/file_block_manager.h
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
M src/kudu/gutil/algorithm.h
M src/kudu/gutil/port.h
M src/kudu/gutil/stl_util.h
M src/kudu/gutil/strings/stringpiece.cc
M src/kudu/gutil/strings/stringpiece.h
M src/kudu/gutil/sysinfo.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/client-stress-test.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/create-table-stress-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/external_mini_cluster-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/flex_partitioning-itest.cc
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.h
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/registration-test.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/integration-tests/update_scan_delta_compact-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-test-util.h
M src/kudu/master/master-test.cc
M src/kudu/master/master.cc
M src/kudu/master/master.h
M src/kudu/master/master_rpc.cc
M src/kudu/master/master_rpc.h
M src/kudu/master/master_service.cc
M src/kudu/master/master_service.h
M src/kudu/master/mini_master.cc
M src/kudu/master/sys_catalog-test.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/master/ts_descriptor.h
M src/kudu/master/ts_manager.cc
M src/kudu/master/ts_manager.h
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/auth_store.cc
M src/kudu/rpc/auth_store.h
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/outbound_call.h
M src/kudu/rpc/protoc-gen-krpc.cc
M src/kudu/rpc/proxy.cc
M src/kudu/rpc/proxy.h
M src/kudu/rpc/reactor-test.cc
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/reactor.h
M src/kudu/rpc/rpc-bench.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc.cc
M src/kudu/rpc/rpc.h
M src/kudu/rpc/rpc_controller.h
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/rpc/sasl_server.cc
M src/kudu/rpc/sasl_server.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/generic_service.cc
M src/kudu/server/rpc_server.cc
M src/kudu/server/rpc_server.h
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/rpcz-path-handler.h
M src/kudu/server/server_base.cc
M src/kudu/server/server_base.h
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/tablet/cfile_set-test.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/compaction.h
M src/kudu/tablet/compaction_policy-test.cc
M src/kudu/tablet/compaction_policy.h
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_applier.cc
M src/kudu/tablet/delta_applier.h
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_compaction.h
M src/kudu/tablet/delta_iterator_merger.cc
M src/kudu/tablet/delta_iterator_merger.h
M src/kudu/tablet/delta_stats.h
M src/kudu/tablet/delta_store.cc
M src/kudu/tablet/delta_store.h
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltafile.h
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
M src/kudu/tablet/diskrowset-test-base.h
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/diskrowset.h
M src/kudu/tablet/lock_manager-test.cc
M src/kudu/tablet/maintenance_manager-test.cc
M src/kudu/tablet/maintenance_manager.cc
M src/kudu/tablet/maintenance_manager.h
M src/kudu/tablet/major_delta_compaction-test.cc
M src/kudu/tablet/memrowset-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/metadata-test.cc
M src/kudu/tablet/mock-rowsets.h
M src/kudu/tablet/mt-diskrowset-test.cc
M src/kudu/tablet/mt-rowset_delta_compaction-test.cc
M src/kudu/tablet/mt-tablet-test.cc
M src/kudu/tablet/mvcc.h
M src/kudu/tablet/rowset.cc
M src/kudu/tablet/rowset.h
M src/kudu/tablet/rowset_info.cc
M src/kudu/tablet/rowset_tree-test.cc
M src/kudu/tablet/rowset_tree.cc
M src/kudu/tablet/rowset_tree.h
M src/kudu/tablet/svg_dump.cc
M src/kudu/tablet/svg_dump.h
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet-pushdown-test.cc
M src/kudu/tablet/tablet-schema-test.cc
M src/kudu/tablet/tablet-test-base.h
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tablet/tablet_mm_ops-test.cc
M src/kudu/tablet/tablet_peer-test.cc
M src/kudu/tablet/tablet_peer.cc
M src/kudu/tablet/tablet_peer.h
M src/kudu/tablet/tablet_random_access-test.cc
M src/kudu/tablet/transactions/alter_schema_transaction.cc
M src/kudu/tablet/transactions/alter_schema_transaction.h
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/transaction_tracker-test.cc
M src/kudu/tablet/transactions/transaction_tracker.cc
M src/kudu/tablet/transactions/transaction_tracker.h
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tablet/transactions/write_transaction.h
M src/kudu/tools/create-demo-table.cc
M src/kudu/tools/fs_dump-tool.cc
M src/kudu/tools/fs_list-tool.cc
M src/kudu/tools/fs_tool.cc
M src/kudu/tools/fs_tool.h
M src/kudu/tools/insert-generated-rows.cc
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-admin.cc
M src/kudu/tools/kudu-ksck.cc
M src/kudu/tools/ts-cli.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/remote_bootstrap_client-test.cc
M src/kudu/tserver/remote_bootstrap_client.cc
M src/kudu/tserver/remote_bootstrap_client.h
M src/kudu/tserver/remote_bootstrap_service.h
M src/kudu/tserver/remote_bootstrap_session-test.cc
M src/kudu/tserver/remote_bootstrap_session.cc
M src/kudu/tserver/remote_bootstrap_session.h
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
M src/kudu/tserver/tablet_peer_lookup.h
M src/kudu/tserver/tablet_server-test-base.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/tserver/tablet_server_test_util.cc
M src/kudu/tserver/tablet_server_test_util.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tablet_service.h
M src/kudu/tserver/ts_tablet_manager-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/twitter-demo/ingest_firehose.cc
M src/kudu/twitter-demo/insert_consumer.cc
M src/kudu/twitter-demo/insert_consumer.h
M src/kudu/twitter-demo/twitter-schema.h
M src/kudu/util/atomic-test.cc
M src/kudu/util/blocking_queue-test.cc
M src/kudu/util/blocking_queue.h
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/debug/trace_event_impl.h
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/env_util.cc
M src/kudu/util/env_util.h
M src/kudu/util/failure_detector.cc
M src/kudu/util/failure_detector.h
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flag_tags.cc
M src/kudu/util/flag_tags.h
M src/kudu/util/flags.cc
M src/kudu/util/kernel_stack_watchdog.cc
M src/kudu/util/kernel_stack_watchdog.h
M src/kudu/util/locks.h
M src/kudu/util/logging-test.cc
A src/kudu/util/logging_test_util.h
M src/kudu/util/mem_tracker-test.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
M src/kudu/util/memcmpable_varint-test.cc
M src/kudu/util/memenv/memenv-test.cc
M src/kudu/util/memory/arena-test.cc
M src/kudu/util/memory/arena.cc
M src/kudu/util/memory/arena.h
M src/kudu/util/memory/memory.h
M src/kudu/util/metrics-test.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
M src/kudu/util/mt-metrics-test.cc
M src/kudu/util/mt-threadlocal-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/sockaddr.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/pstack_watcher-test.cc
M src/kudu/util/pstack_watcher.cc
D src/kudu/util/shared_ptr_util.h
M src/kudu/util/striped64-test.cc
M src/kudu/util/subprocess.cc
M src/kudu/util/sync_point.h
M src/kudu/util/test_graph.cc
M src/kudu/util/test_graph.h
M src/kudu/util/thread.cc
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
M thirdparty/.gitignore
M thirdparty/build-if-necessary.sh
M thirdparty/build-thirdparty.sh
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-devtoolset-toolchain.patch
M thirdparty/patches/llvm-fix-amazon-linux.patch
D thirdparty/patches/llvm-fix-jit-debugging.patch
D thirdparty/patches/llvm-stop-including-msan_interface.patch
M thirdparty/vars.sh
401 files changed, 2,327 insertions(+), 2,725 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/1687/5
-- 
To view, visit http://gerrit.cloudera.org:8080/1687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic52cbf98f583a3a953b1910e0017a8af448660d7
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@cloudera.com>