You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yingjieMiao <gi...@git.apache.org> on 2014/09/27 02:26:55 UTC
[GitHub] spark pull request: graphX page rank: test convergence bug
GitHub user yingjieMiao opened a pull request:
https://github.com/apache/spark/pull/2550
graphX page rank: test convergence bug
We stop sending messages when `delta` is no bigger than `tol`. Test convergence would fail if there is a big negative change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yingjieMiao/spark page_rank
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2550.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2550
----
commit 3317b9589d9966778dccaa1f11bf8449d8d6ca4e
Author: yingjieMiao <yi...@42go.com>
Date: 2014-09-27T00:21:05Z
page rank: test convergence bug
commit d2e973e4c320766aa0075153f4869c87b212d1b2
Author: yingjieMiao <yi...@42go.com>
Date: 2014-09-27T00:22:00Z
Revert "page rank: test convergence bug"
This reverts commit 3317b9589d9966778dccaa1f11bf8449d8d6ca4e.
commit 27cc7a506a8fecb2c5527ac52575f6c6e9092c5a
Author: yingjieMiao <yi...@42go.com>
Date: 2014-09-27T00:22:22Z
Merge branch 'master' of git://github.com/apache/spark
commit 9e97611dc1fd271acf305513fdee12f41dcc0eb4
Author: yingjieMiao <yi...@42go.com>
Date: 2014-09-27T00:23:59Z
graphX page rank: test convergence bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: graphX page rank: test convergence bug
Posted by yingjieMiao <gi...@git.apache.org>.
Github user yingjieMiao closed the pull request at:
https://github.com/apache/spark/pull/2550
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: graphX page rank: test convergence bug
Posted by ankurdave <gi...@git.apache.org>.
Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/2550#issuecomment-57035975
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: graphX page rank: test convergence bug
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2550#issuecomment-57036257
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20891/consoleFull) for PR 2550 at commit [`9e97611`](https://github.com/apache/spark/commit/9e97611dc1fd271acf305513fdee12f41dcc0eb4).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: graphX page rank: test convergence bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2550#issuecomment-57035892
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: graphX page rank: test convergence bug
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2550#issuecomment-57038084
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20891/consoleFull) for PR 2550 at commit [`9e97611`](https://github.com/apache/spark/commit/9e97611dc1fd271acf305513fdee12f41dcc0eb4).
* This patch **fails** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: graphX page rank: test convergence bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2550#issuecomment-57038087
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20891/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: graphX page rank: test convergence bug
Posted by yingjieMiao <gi...@git.apache.org>.
Github user yingjieMiao commented on the pull request:
https://github.com/apache/spark/pull/2550#issuecomment-57036838
sorry, this is not necessary. PageRank at a point is monotonically increasing and converges to a bound.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org