You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/05/12 05:43:43 UTC

[PR] fix: align BroadcastPartition routing in LinkConfig with broadcast semantics [texera]

Ma77Ball opened a new pull request, #5032:
URL: https://github.com/apache/texera/pull/5032

    ### What changes were proposed in this PR?
     `LinkConfig.toPartitioning`'s `BroadcastPartition()` arm was building channels with `fromWorkerIds.zip(toWorkerIds)`, producing a 1:1 pairing rather than the full sender-by-receiver cross product that broadcast semantics imply.
      The sibling `ChannelConfig.generateChannelConfigs` in the same package already emits a cross product for the broadcast arm, so the two helpers disagreed on routing for the same inputs. As with #4799 for `OneToOnePartition`,
     `List.zip` also silently truncated the surplus side on unequal-length inputs. This PR replaces the `zip` with the same `flatMap` / `map` cross product already used by the `HashPartition`, `RangePartition`, and
     `UnknownPartition` arms in this file, which fixes the semantics and removes the silent truncation hazard.
   
     ### Any related issues, documentation, or discussions?
     Closes: #4802
     
     ### How was this PR tested?
     The two `LinkConfigSpec` cases that pinned the previous behavior (with comments explicitly inviting this realignment) were flipped to assert the cross product: 3 senders by 3 receivers now produces 9 channels, and the
     Asymmetric 3 by 2 case now produces 6 channels rather than silently truncating to 2. `sbt scalafmtAll` was run; CI should pass the existing `LinkConfigSpec`, `ChannelConfigSpec`, and downstream scheduling specs.
     
     ### Was this PR authored or co-authored using generative AI tooling?
     Co-authored with Claude Opus 4.7 in compliance with ASF


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: align BroadcastPartition routing in LinkConfig with broadcast semantics [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5032:
URL: https://github.com/apache/texera/pull/5032#issuecomment-4434300086

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5032?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 42.72%. Comparing base ([`7879c2a`](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f290dd6`](https://app.codecov.io/gh/apache/texera/commit/f290dd643e822bb6615dd9609d40bae91a6913a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #5032      +/-   ##
   ============================================
   - Coverage     42.73%   42.72%   -0.02%     
   + Complexity     2191     2188       -3     
   ============================================
     Files          1045     1045              
     Lines         39979    39979              
     Branches       4218     4218              
   ============================================
   - Hits          17087    17083       -4     
   - Misses        21835    21838       +3     
   - Partials       1057     1058       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.53% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.72% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.36% <100.00%> (-0.03%)` | :arrow_down: | |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.18% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.04% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [python](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.90% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5032/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.72% <ø> (ø)` | | Carriedforward from [7879c2a](https://app.codecov.io/gh/apache/texera/commit/7879c2a10f1b7d0c403515451c5f0c7a7c630ac0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/texera/pull/5032?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: align BroadcastPartition routing in LinkConfig with broadcast semantics [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #5032:
URL: https://github.com/apache/texera/pull/5032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: align BroadcastPartition routing in LinkConfig with broadcast semantics [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5032:
URL: https://github.com/apache/texera/pull/5032#issuecomment-4434198162

   /request-review @aglinxinyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: align BroadcastPartition routing in LinkConfig with broadcast semantics [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5032:
URL: https://github.com/apache/texera/pull/5032#issuecomment-4436621681

   @aglinxinyuan, thank you for the review. When available, please merge. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org