[GitHub] [daffodil-vscode] shanedell commented on a diff in pull request #725: Data Editor Improvements for v1.3.1

["shanedell (via GitHub)" <gi...@apache.org>]

shanedell commented on code in PR #725:
URL: https://github.com/apache/daffodil-vscode/pull/725#discussion_r1280829593


##########
.github/workflows/CI.yml:
##########
@@ -111,9 +112,15 @@ jobs:
       - run: $SBT compile # used to initialize sbt, if not done sbt universal:packageBin ran by yarn package times out -- windows only
         if: runner.os == 'Windows'
       - run: yarn install
+      - name: Make sure the Ωedit server can start on port 9009

Review Comment:
   This should not be needed. During the package of the server it runs a `chmod +x` on the server binary.



##########
.vscode/launch.json:
##########
@@ -18,6 +18,24 @@
 {
 	"version": "0.2.0",
 	"configurations": [
+		{
+			"type": "dfdl",
+			"request": "launch",
+			"name": "DfdlDeb",
+			"program": "${command:AskForProgramName}",
+			"stopOnEntry": true,
+			"data": "${command:AskForDataName}",
+			"infosetFormat": "xml",
+			"infosetOutput": {
+				"type": "file",
+				"path": "${workspaceFolder}/infoset.xml"
+			},
+			"debugServer": 4711,
+			"openHexView": false,
+			"openInfosetView": false,
+			"openInfosetDiffView": false,
+			"daffodilDebugClasspath": ""
+		},

Review Comment:
   Remove this. This is a daffodil debugger launch config, it should not be inside of `daffodil-vscode`. This type of launch config does not live in this repo as it should be local to schemas you are debuggering.
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org