You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2006/04/09 17:53:30 UTC
DO NOT REPLY [Bug 39256] New: - Patch: TextBox shape, how-to guide and misc. refactoring
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39256>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39256
Summary: Patch: TextBox shape, how-to guide and misc. refactoring
Product: POI
Version: unspecified
Platform: Other
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: HSLF
AssignedTo: poi-dev@jakarta.apache.org
ReportedBy: yegor@dinom.ru
Commit notes:
(1) More refactoring of the code.
Summary of Changes
- SlideShow, Sheet and Shape should be navigatable in both directions, i.e.
given a shape it should be possible to get the owning sheet and given a sheet
get the owning SlideShow:
Shape shape = ....;
Sheet sheet = shape.getSheet();
SlideShow ppt = sheet.getSlideShow();
I added the required members and accessors to Sheet and Shape. Also had to make
SlideShow.getDocumentRecord public
since we need to access it outside of usermodel package.
- Added default constructors to create new TextBytesAtom, StyleTextPropAtom,
EscherTextboxWrapper and TextHeaderAtom
- added PPDrawing.addTextboxWrapper.
If we add a new EscherTextbox we need to tell about it to the owning PPDrawing
container.
(2) TextBox shape is implemented. It depends on Bug 39177 (TextRun.setText sets
incorrect length of text in the underlying StyleTextPropAtom).
So this bug becomes a blocker.
Nick, do you have serious reasons to delay commit with its fix?
I'm ready to discuss it or take responsibility to write more tests, etc.
(3) A quick how-to guide on how to work with shapes in HSLF.
(See src\documentation\content\xdocs\hslf\how-to.xml)
If see that the English is clumsy or there are errors please change them without
hesitation.
(4) src\scratchpad\src\org\apache\poi\hslf\data\empty.ppt
Changed document properties, set Author and Company to Apache Software Foundation.
Best Regards, Yegor Kozlov
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 39256] - Patch: TextBox shape, how-to guide and misc. refactoring
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39256>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39256
------- Additional Comments From yegor@dinom.ru 2006-04-09 16:55 -------
Created an attachment (id=18047)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18047&action=view)
archive with the affected source code
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 39256] - Patch: TextBox shape, how-to guide and misc. refactoring
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39256>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39256
------- Additional Comments From yegor@dinom.ru 2006-04-09 16:54 -------
Created an attachment (id=18046)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=18046&action=view)
patch with changes
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
DO NOT REPLY [Bug 39256] - Patch: TextBox shape, how-to guide and misc. refactoring
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39256>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39256
nick@torchbox.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From nick@torchbox.com 2006-04-12 19:54 -------
Thanks, I've committed this with only a few tweaks (mostly to comments). I
ditched the empty constructor to StyleTextPropAtom, since you can get the same
behaviour by calling the int constructor with a size 0.
I've also put your new documentation page on the site (just needed a slight
tweak to make the XML valid)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/