You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Vincent Massol <vm...@pivolis.com> on 2005/06/26 18:16:41 UTC

[m2] Clvoer plugin location (was RE: [m2] Forking a custom lifecycle in a report plugin?)


> -----Original Message-----
> From: Jason van Zyl [mailto:jason@maven.org]
> Sent: dimanche 26 juin 2005 16:08
> To: Maven Developers List
> Subject: RE: [m2] Forking a custom lifecycle in a report plugin?
> 
> On Sun, 2005-06-26 at 12:39 +0200, Vincent Massol wrote:
> > Just realized I was missing a META-INF/plexus/components.xml file. Will
> try
> > with one.
> 
> I'm taking a peek. How about we set you up with access to the m2 plugins
> in SVN and we can work on it from there? Anyone object to that? Getting
> the clover plugin working I think would be very nice.

I'd like that now that I'm getting up to speed with m2. However WRT to the
Clover plugin we have 2 options:
- set it up @ apache
- set it up @ cenqua. They have opened an open source area and have invited
me there

I'm not yet sure what makes the most sense. I'd like to get both your
opinion and theirs. I can see pros and cons of each.

Thanks
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [m2] Clvoer plugin location (was RE: [m2] Forking a custom lifecycle in a report plugin?)

Posted by Emmanuel Venisse <em...@venisse.net>.

Trygve Laugstøl wrote:
> On Sun, Jun 26, 2005 at 06:16:41PM +0200, Vincent Massol wrote:
> 
>>
>>>-----Original Message-----
>>>From: Jason van Zyl [mailto:jason@maven.org]
>>>Sent: dimanche 26 juin 2005 16:08
>>>To: Maven Developers List
>>>Subject: RE: [m2] Forking a custom lifecycle in a report plugin?
>>>
>>>On Sun, 2005-06-26 at 12:39 +0200, Vincent Massol wrote:
>>>
>>>>Just realized I was missing a META-INF/plexus/components.xml file. Will
>>>>try with one.
>>>
>>>I'm taking a peek. How about we set you up with access to the m2 plugins
>>>in SVN and we can work on it from there? Anyone object to that? Getting
>>>the clover plugin working I think would be very nice.
>>
>>I'd like that now that I'm getting up to speed with m2. However WRT to the
>>Clover plugin we have 2 options:
>>- set it up @ apache
>>- set it up @ cenqua. They have opened an open source area and have invited
>>me there
>>
>>I'm not yet sure what makes the most sense. I'd like to get both your
>>opinion and theirs. I can see pros and cons of each.
> 
> 
> I would say add it in the Apache repository first so we can all work on it
> as it might require changes in Maven 2 itself and having it in our
> repository just makes life easier for us. When it's getting close to a 1.0
> release (or around the 2.0 final release of Maven 2) move it to Cenqua so
> they'll maintain it.

+1

Emmanuel

> 
> Btw, it's really nice to see people having a OSS area and are willing to
> maintain the plugins for Maven.
> 
> 
>>Thanks
>>-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [m2] Clvoer plugin location (was RE: [m2] Forking a custom lifecycle in a report plugin?)

Posted by Emmanuel Venisse <em...@venisse.net>.
Jason van Zyl wrote:
> On Mon, 2005-06-27 at 08:31 +0200, Vincent Massol wrote:
> 
>>>-----Original Message-----
>>>From: Trygve Laugstøl [mailto:trygvela@student.matnat.uio.no]
>>>Sent: lundi 27 juin 2005 01:34
>>>To: Maven Developers List
>>>Subject: Re: [m2] Clvoer plugin location (was RE: [m2] Forking a custom
>>>lifecycle in a report plugin?)
>>
>>[snip]
>> 
>>
>>>I would say add it in the Apache repository first so we can all work on it
>>>as it might require changes in Maven 2 itself and having it in our
>>>repository just makes life easier for us. When it's getting close to a 1.0
>>>release (or around the 2.0 final release of Maven 2) move it to Cenqua so
>>>they'll maintain it.
>>
>>I've just received an email from Cenqua saying that we should put it in the
>>Apache repo for now if we accept it because their OSS area is not up to the
>>par yet with Apache infrastructure (SCM, JIRA, Confluence, etc). As you say
>>we can always move it to Cenqua later on as they're happy with this too.
>>We'll see when the time comes.
>> 
>>
>>>Btw, it's really nice to see people having a OSS area and are willing to
>>>maintain the plugins for Maven.
>>
>>I agree, that's very cool.
> 
> 
> Vincent, we don't really have a sandbox area setup so I think everyone
> would agree that you having access to:
> 

+1

Emmanuel

> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-plugins/
> 
> Is just fine so you're setup there.
> 
> Sorry for the delay, just got back from JavaOne.
> 
> 
>>Thanks
>>-Vincent
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>For additional commands, e-mail: dev-help@maven.apache.org
>>
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mixed plugins and functional tests for plugins? (was RE: [m2] Clvoer plugin location (was RE: [m2] Forking a customlifecycle in a report plugin?))

Posted by Vincent Massol <vm...@pivolis.com>.

> -----Original Message-----
> From: Jason van Zyl [mailto:jason@maven.org]
> Sent: dimanche 3 juillet 2005 19:11
> To: Maven Developers List
> Subject: RE: [m2] Clvoer plugin location (was RE: [m2] Forking a
> customlifecycle in a report plugin?)

[snip]

> Vincent, we don't really have a sandbox area setup so I think everyone
> would agree that you having access to:
> 
> http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-plugins/
> 
> Is just fine so you're setup there.
> 
> Sorry for the delay, just got back from JavaOne.

Thanks. I'll commit what I have of the clover plugin later this week.

Before doing that I have 2 questions:

1/ The Clover plugin is a mix of "standard" mojos and report mojos. Where
should it live? It seems you've made a distinction between report plugins
and other plugins. I believe that most plugin are actually a mix. For
example the checkstyle plugin should have a mojo for failing the build in
case of violation.

2/ What directory structure do you want for functional tests for plugins?
Here's what I currently have:

maven-clover-plugin/
  |_ plugin/
  |_ samples/
    |_ simple/

Where plugin/ is the directory of the plugin sources, samples/ the directory
where samples acting as functional tests are found and simple/ is one simple
sample. There could be more than one in the future.

This does not fit the plugin structure I have seen so far because current
plugins do not have functional tests (most do not even have unit tests
actually).

I had discussed this with Trygve a bit on IRC and Trygve was suggesting that
I consider functional tests as unit tests and put them in src/test/java.
That would mean embedding Maven in the tests itself.

I think there's some value in that but it's beyond my current knowledge to
do so. I do believe it would be nice to create a functional maven tester
plugin that would execute Maven projects located in directories specified in
a config element in the POM (say it would default to src/test/projects). The
plugin would embed an m2 instance and execute the defined projects. This
plugin would be bound to the functional-test phase.

This would allow us to have the following plugin source structure:

maven-clover-plugin/
  |_ src/
    |_ main/
    |_ test/
      |_ java/ <-- unit tests only
      |_ projects/
        |_ simple/

The plugin's POM would reference the maven tester plugin so that it is
bound to the functional-test phase and running "m2 install" would trigger
it.
 
WDYT?

Thanks
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: [m2] Clvoer plugin location (was RE: [m2] Forking a custom lifecycle in a report plugin?)

Posted by Jason van Zyl <ja...@maven.org>.
On Mon, 2005-06-27 at 08:31 +0200, Vincent Massol wrote:
> 
> > -----Original Message-----
> > From: Trygve Laugstøl [mailto:trygvela@student.matnat.uio.no]
> > Sent: lundi 27 juin 2005 01:34
> > To: Maven Developers List
> > Subject: Re: [m2] Clvoer plugin location (was RE: [m2] Forking a custom
> > lifecycle in a report plugin?)
> 
> [snip]
>  
> > I would say add it in the Apache repository first so we can all work on it
> > as it might require changes in Maven 2 itself and having it in our
> > repository just makes life easier for us. When it's getting close to a 1.0
> > release (or around the 2.0 final release of Maven 2) move it to Cenqua so
> > they'll maintain it.
> 
> I've just received an email from Cenqua saying that we should put it in the
> Apache repo for now if we accept it because their OSS area is not up to the
> par yet with Apache infrastructure (SCM, JIRA, Confluence, etc). As you say
> we can always move it to Cenqua later on as they're happy with this too.
> We'll see when the time comes.
>  
> > Btw, it's really nice to see people having a OSS area and are willing to
> > maintain the plugins for Maven.
> 
> I agree, that's very cool.

Vincent, we don't really have a sandbox area setup so I think everyone
would agree that you having access to:

http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-plugins/

Is just fine so you're setup there.

Sorry for the delay, just got back from JavaOne.

> Thanks
> -Vincent
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 
-- 
jvz.

Jason van Zyl
jason at maven.org
http://maven.apache.org

the course of true love never did run smooth ...

 -- Shakespeare


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: [m2] Clvoer plugin location (was RE: [m2] Forking a custom lifecycle in a report plugin?)

Posted by Vincent Massol <vm...@pivolis.com>.

> -----Original Message-----
> From: Trygve Laugstøl [mailto:trygvela@student.matnat.uio.no]
> Sent: lundi 27 juin 2005 01:34
> To: Maven Developers List
> Subject: Re: [m2] Clvoer plugin location (was RE: [m2] Forking a custom
> lifecycle in a report plugin?)

[snip]
 
> I would say add it in the Apache repository first so we can all work on it
> as it might require changes in Maven 2 itself and having it in our
> repository just makes life easier for us. When it's getting close to a 1.0
> release (or around the 2.0 final release of Maven 2) move it to Cenqua so
> they'll maintain it.

I've just received an email from Cenqua saying that we should put it in the
Apache repo for now if we accept it because their OSS area is not up to the
par yet with Apache infrastructure (SCM, JIRA, Confluence, etc). As you say
we can always move it to Cenqua later on as they're happy with this too.
We'll see when the time comes.
 
> Btw, it's really nice to see people having a OSS area and are willing to
> maintain the plugins for Maven.

I agree, that's very cool.

Thanks
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [m2] Clvoer plugin location (was RE: [m2] Forking a custom lifecycle in a report plugin?)

Posted by Trygve Laugstøl <tr...@student.matnat.uio.no>.
On Sun, Jun 26, 2005 at 06:16:41PM +0200, Vincent Massol wrote:
> 
> 
> > -----Original Message-----
> > From: Jason van Zyl [mailto:jason@maven.org]
> > Sent: dimanche 26 juin 2005 16:08
> > To: Maven Developers List
> > Subject: RE: [m2] Forking a custom lifecycle in a report plugin?
> > 
> > On Sun, 2005-06-26 at 12:39 +0200, Vincent Massol wrote:
> > > Just realized I was missing a META-INF/plexus/components.xml file. Will
> > > try with one.
> > 
> > I'm taking a peek. How about we set you up with access to the m2 plugins
> > in SVN and we can work on it from there? Anyone object to that? Getting
> > the clover plugin working I think would be very nice.
> 
> I'd like that now that I'm getting up to speed with m2. However WRT to the
> Clover plugin we have 2 options:
> - set it up @ apache
> - set it up @ cenqua. They have opened an open source area and have invited
> me there
> 
> I'm not yet sure what makes the most sense. I'd like to get both your
> opinion and theirs. I can see pros and cons of each.

I would say add it in the Apache repository first so we can all work on it
as it might require changes in Maven 2 itself and having it in our
repository just makes life easier for us. When it's getting close to a 1.0
release (or around the 2.0 final release of Maven 2) move it to Cenqua so
they'll maintain it.

Btw, it's really nice to see people having a OSS area and are willing to
maintain the plugins for Maven.

> 
> Thanks
> -Vincent