[GitHub] [airflow] ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #6553: [AIRFLOW-5902] avoid unnecessary sleep to maintain local task job heart rate
URL: https://github.com/apache/airflow/pull/6553#discussion_r349699789
 
 

 ##########
 File path: airflow/jobs/base_job.py
 ##########
 @@ -171,17 +171,14 @@ def heartbeat(self):
             if self.state == State.SHUTDOWN:
                 self.kill()
 
-            is_unit_test = conf.getboolean('core', 'unit_test_mode')
 
 Review comment:
   > I am thinking of patching sleep globally for all unit tests, so we won't have to worry about it going forward. is this the kind of change you all comfortable with?
   
   No, sometimes we _need_ sleep in our tests to give a sub-process time to do start up etc.(mostly tests, not in the airflow core), or in the dags to "do nothing for a long time" so this would break all sorts of things.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services