You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "KKcorps (via GitHub)" <gi...@apache.org> on 2026/09/07 05:54:10 UTC
[PR] Allow deferring single-segment metadata push failure cleanup [pinot]
KKcorps opened a new pull request, #19487:
URL: https://github.com/apache/pinot/pull/19487
Metadata push can throw after the controller has registered the segment URI, for example when the client loses the response. Executors that publish a fresh immutable URI per attempt need to retain that output until they reconcile controller metadata.
Extract the existing failure deletion into a protected `cleanupMetadataPushFailure(PinotFS, URI)` hook. This lets those executors defer cleanup without duplicating the single-segment conversion/upload lifecycle. The default implementation retains the existing deletion behavior, and the upload exception still propagates to fail the task.
Validation: all four `BaseSingleSegmentConversionExecutorTest` cases passed, including the existing cleanup test and a new override test that retains the output while propagating the error. Sources were recompiled and run with TestNG against the locally cached dependency classpath. The Maven test lifecycle was blocked by uncached `protobuf-java:4.36.1` and `snakeyaml:2.7`; CI still needs to validate current dependency resolution. Module-scoped Spotless, Checkstyle, license format/check, and `git diff --check` passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Use immutable outputs for same-name minion metadata pushes [pinot]
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps commented on PR #19487:
URL: https://github.com/apache/pinot/pull/19487#issuecomment-5566823725
Closing this PR because the implementation is not clean enough and needs to be rethought. The approach to same-name metadata pushes and output cleanup needs a simpler design before we proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Use immutable outputs for same-name minion metadata pushes [pinot]
Posted by "KKcorps (via GitHub)" <gi...@apache.org>.
KKcorps closed pull request #19487: Use immutable outputs for same-name minion metadata pushes
URL: https://github.com/apache/pinot/pull/19487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Allow deferring single-segment metadata push failure cleanup [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19487:
URL: https://github.com/apache/pinot/pull/19487#issuecomment-5566059324
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19487?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 57.78%. Comparing base ([`1f17ab0`](https://app.codecov.io/gh/apache/pinot/commit/1f17ab0ede12e2703e4a037837d4c641c4756d11?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`102c697`](https://app.codecov.io/gh/apache/pinot/commit/102c697a07cdec0adcd0f15366d77328f453ada4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (1f17ab0) and HEAD (102c697). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (1f17ab0) | HEAD (102c697) |
>|------|------|------|
>|unittests|2|1|
>|java-25|6|1|
>|temurin|6|1|
>|unittests2|1|0|
>|lane-a|2|0|
>|integration|4|0|
>|integration2|2|0|
>|lane-b|2|0|
>|integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19487 +/- ##
============================================
- Coverage 67.70% 57.78% -9.93%
+ Complexity 1430 1 -1429
============================================
Files 3488 2685 -803
Lines 224404 164185 -60219
Branches 35427 26662 -8765
============================================
- Hits 151938 94874 -57064
- Misses 60466 61288 +822
+ Partials 12000 8023 -3977
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.78% <ø> (-9.93%)` | :arrow_down: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.78% <ø> (-9.93%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.78% <ø> (-9.92%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.78% <ø> (+0.02%)` | :arrow_up: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19487/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19487?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org