You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/24 14:36:43 UTC
[GitHub] [airflow] chamorin opened a new pull request #17813: Fixed numeric list
chamorin opened a new pull request #17813:
URL: https://github.com/apache/airflow/pull/17813
Just fixes the first element of the numeric list in the `DebugExecutor` doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17813: Fixed numeric list
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17813:
URL: https://github.com/apache/airflow/pull/17813#issuecomment-904827251
Or the following to skip spelling checks:
```
❯ ./breeze build-docs -- --package-filter=apache-airflow --docs-only
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #17813: Fixed numeric list
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #17813:
URL: https://github.com/apache/airflow/pull/17813#issuecomment-904784135
I don’t think this would render as we want. The paragraph and code block likely need to be indented.
p.s. you can check how this renders with `./breeze build-docs --package-filter=apache-airflow` and open `docs/_build/docs/apache-airflow/latest/executor/debug.html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17813: Fixed numeric list
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17813:
URL: https://github.com/apache/airflow/pull/17813#issuecomment-904699559
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #17813: Fixed numeric list
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #17813:
URL: https://github.com/apache/airflow/pull/17813#issuecomment-904871862
> I don’t think this would render as we want. The paragraph and code block likely need to be indented.
>
> p.s. you can check how this renders with `./breeze build-docs --package-filter=apache-airflow` and open `docs/_build/docs/apache-airflow/latest/executor/debug.html`
Merging since it is rendered fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17813: Fixed numeric list
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17813:
URL: https://github.com/apache/airflow/pull/17813#issuecomment-904871978
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17813: Fixed numeric list
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17813:
URL: https://github.com/apache/airflow/pull/17813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17813: Fixed numeric list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17813:
URL: https://github.com/apache/airflow/pull/17813#issuecomment-904762946
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org