You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2023/01/13 10:28:57 UTC

[GitHub] [jackrabbit-oak] kwin commented on a diff in pull request #823: OAK-10001: Bump up minimal Java version to 11

kwin commented on code in PR #823:
URL: https://github.com/apache/jackrabbit-oak/pull/823#discussion_r1069214280


##########
oak-parent/pom.xml:
##########
@@ -111,25 +110,17 @@
       <plugins>
         <plugin>
           <artifactId>maven-compiler-plugin</artifactId>
+          <version>3.8.1</version>
           <configuration>
+            <target>${java.version}</target>
+            <source>${java.version}</source>
+            <release>${java.version}</release>

Review Comment:
   Rather overwrite `maven.compiler.target` and set `maven.compiler.release` as well to the same value, as that also affects m-javadoc-p, ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org