[GitHub] [metron] justinleet commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1

[GitBox <gi...@apache.org>]

justinleet commented on a change in pull request #1551: METRON-2223 Reconcile Versions in Root POM with HDP 3.1
URL: https://github.com/apache/metron/pull/1551#discussion_r341392736
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -185,11 +167,6 @@
                 <artifactId>mockito-core</artifactId>
                 <version>${global_mockito_version}</version>
             </dependency>
-            <dependency>
-                <groupId>org.apache.storm</groupId>
-                <artifactId>storm-kafka</artifactId>
 
 Review comment:
   I'm not sure why we have it here, but it's not a dependency directly. It's in the dependencyManagement section, so it's theoretically defining a dependency that children can use without having to specify the version (i.e. instead of the various global params we use, you could also define it here, and the children would just say the group/id). I believe it can also be useful for doing things like moving exclusions to be declared in a single place (e.g. always removing logging deps), but my recollection is a bit hazy.
   
   If it were actually used however, the build would have broken. I have no idea why we have the section in general, because we don't actually use it the way it would be intended.
   
   And I'm also scared to look at the git blame, because there's an extremely nonzero chance I did it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services