[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4517: [FLINK] Fix multiple executions lead to abnormal results on Flink 1.14

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4517:
URL: https://github.com/apache/kyuubi/pull/4517#discussion_r1136575060


##########
externals/kyuubi-flink-sql-engine/src/main/java/org/apache/kyuubi/engine/flink/result/ResultSet.java:
##########
@@ -108,7 +113,26 @@ public String toString() {
         + '}';
   }
 
+  /**
+   * Before version 1.15(FLINK-25558), there were concurrency issues.
+   *
+   * @return TableResult.
+   */
+  public static TableResult createResultOk() {

Review Comment:
   please inline this function and comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org