You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/11 18:40:00 UTC

[jira] [Work logged] (ARTEMIS-3872) Send scheduled message immediately via mangement

     [ https://issues.apache.org/jira/browse/ARTEMIS-3872?focusedWorklogId=789707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789707 ]

ASF GitHub Bot logged work on ARTEMIS-3872:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jul/22 18:39
            Start Date: 11/Jul/22 18:39
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #4120:
URL: https://github.com/apache/activemq-artemis/pull/4120#discussion_r918242282


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -2018,7 +2018,20 @@ public void incrementMesssagesAdded() {
 
    @Override
    public void deliverScheduledMessages() throws ActiveMQException {
-      List<MessageReference> scheduledMessages = scheduledDeliveryHandler.cancel(null);
+      internalDeliverScheduleMessages(scheduledDeliveryHandler.cancel(ref -> true));
+   }
+
+   @Override
+   public void deliverScheduledMessages(String filterString) throws ActiveMQException {
+      internalDeliverScheduleMessages(scheduledDeliveryHandler.cancel(ref -> filterString == null || filterString.length() == 0 ? true : FilterImpl.createFilter(filterString).match(ref.getMessage())));

Review Comment:
   Great suggestion!





Issue Time Tracking
-------------------

    Worklog Id:     (was: 789707)
    Time Spent: 20m  (was: 10m)

> Send scheduled message immediately via mangement
> ------------------------------------------------
>
>                 Key: ARTEMIS-3872
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3872
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)