You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/12/08 01:23:43 UTC
[PR] [improve](move-memtable) include and check offset when append data [doris]
kaijchen opened a new pull request, #28159:
URL: https://github.com/apache/doris/pull/28159
## Proposed changes
Include and check offset when append data, for data integrity.
Also enhance error checking in `LoadStreamWriter`.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846413930
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846456416
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.16 seconds
stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17212467324 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847147388
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit d6e29351e5a6d577b01f21c40df77839b60b0af8, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4647 4418 4451 4418
q2 360 183 157 157
q3 1443 1253 1238 1238
q4 1102 943 919 919
q5 3098 3091 3121 3091
q6 246 131 128 128
q7 1021 482 476 476
q8 2155 2225 2143 2143
q9 6632 6628 6664 6628
q10 3194 3239 3257 3239
q11 322 205 210 205
q12 352 208 206 206
q13 4566 3842 3807 3807
q14 244 212 214 212
q15 574 525 526 525
q16 447 387 385 385
q17 1004 595 583 583
q18 7465 7288 7002 7002
q19 1512 1353 1371 1353
q20 506 357 318 318
q21 3087 2615 2590 2590
q22 340 284 280 280
Total cold run time: 44317 ms
Total hot run time: 39903 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4425 4415 4404 4404
q2 264 168 174 168
q3 3515 3506 3517 3506
q4 2373 2359 2368 2359
q5 5722 5702 5693 5693
q6 239 121 125 121
q7 2387 1921 1877 1877
q8 3478 3488 3489 3488
q9 9004 8946 8963 8946
q10 3868 3987 3980 3980
q11 509 396 380 380
q12 763 608 602 602
q13 4320 3570 3553 3553
q14 298 258 253 253
q15 567 519 520 519
q16 500 447 462 447
q17 1864 1855 1838 1838
q18 8704 8270 8368 8270
q19 1697 1698 1730 1698
q20 2274 1931 1957 1931
q21 6455 6113 6111 6111
q22 497 409 423 409
Total cold run time: 63723 ms
Total hot run time: 60553 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846410712
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846416279
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1848319718
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #28159:
URL: https://github.com/apache/doris/pull/28159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846776890
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846452213
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 4416de38f2201f2c706279b3854c0bd65a461f72, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4698 4437 4509 4437
q2 369 145 159 145
q3 1463 1228 1240 1228
q4 1114 912 888 888
q5 3114 3133 3129 3129
q6 253 130 124 124
q7 1006 488 474 474
q8 2182 2180 2162 2162
q9 6651 6621 6653 6621
q10 3230 3245 3250 3245
q11 331 210 203 203
q12 345 209 207 207
q13 4838 3845 3865 3845
q14 235 208 210 208
q15 563 527 523 523
q16 441 383 385 383
q17 1011 561 538 538
q18 7589 7230 6950 6950
q19 1495 1371 1433 1371
q20 567 828 336 336
q21 3066 2645 2627 2627
q22 360 284 291 284
Total cold run time: 44921 ms
Total hot run time: 39928 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4382 4358 4398 4358
q2 267 162 167 162
q3 3542 3528 3522 3522
q4 2393 2375 2368 2368
q5 5762 5757 5745 5745
q6 240 121 122 121
q7 2403 1882 1881 1881
q8 3515 3519 3524 3519
q9 9040 9034 9038 9034
q10 3931 3996 4008 3996
q11 503 383 387 383
q12 777 601 599 599
q13 4303 3572 3570 3570
q14 284 246 256 246
q15 567 526 515 515
q16 489 428 484 428
q17 1866 1840 1853 1840
q18 8673 8261 8231 8231
q19 1743 1721 1738 1721
q20 2255 1936 1936 1936
q21 6532 6241 6193 6193
q22 512 437 414 414
Total cold run time: 63979 ms
Total hot run time: 60782 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846422434
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847300177
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 3b22efe872527d1cb02250b8430acbcf9084b101, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4648 4533 4467 4467
q2 351 183 158 158
q3 1441 1211 1230 1211
q4 1108 968 955 955
q5 3097 3102 3099 3099
q6 249 131 127 127
q7 1003 479 476 476
q8 2158 2231 2164 2164
q9 6625 6637 6662 6637
q10 3202 3242 3419 3242
q11 322 202 211 202
q12 348 203 201 201
q13 4576 3817 3822 3817
q14 234 210 213 210
q15 565 523 519 519
q16 441 381 387 381
q17 990 566 551 551
q18 8059 7421 6915 6915
q19 1498 1381 1393 1381
q20 962 320 341 320
q21 3057 2649 2602 2602
q22 345 280 288 280
Total cold run time: 45279 ms
Total hot run time: 39915 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4396 4368 4337 4337
q2 269 166 182 166
q3 3524 3503 3495 3495
q4 2372 2373 2367 2367
q5 5724 5673 5701 5673
q6 237 123 122 122
q7 2357 1897 1875 1875
q8 3490 3490 3483 3483
q9 9007 8934 8959 8934
q10 3892 3982 3966 3966
q11 502 372 386 372
q12 755 607 591 591
q13 4283 3535 3510 3510
q14 280 245 250 245
q15 575 524 525 524
q16 514 456 468 456
q17 1875 1830 1848 1830
q18 8617 8248 8547 8248
q19 1736 1693 1731 1693
q20 2236 1944 1927 1927
q21 6473 6125 6113 6113
q22 507 415 428 415
Total cold run time: 63621 ms
Total hot run time: 60342 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847273954
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846784801
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847284798
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847200405
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.74 seconds
stream load tsv: 591 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17211956558 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847375481
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 96a54b662ec2cb990ffb77a3605c24cd1d79e2b1, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4680 4451 4468 4451
q2 355 158 158 158
q3 1450 1246 1231 1231
q4 1104 881 890 881
q5 3118 3109 3104 3104
q6 254 131 129 129
q7 989 480 476 476
q8 2169 2221 2151 2151
q9 6619 6692 6633 6633
q10 3203 3238 3240 3238
q11 329 207 193 193
q12 346 200 202 200
q13 4553 3809 3811 3809
q14 235 213 217 213
q15 565 521 523 521
q16 442 394 381 381
q17 992 563 540 540
q18 7668 7371 7260 7260
q19 1512 1360 1371 1360
q20 536 310 290 290
q21 3018 2616 2718 2616
q22 342 274 281 274
Total cold run time: 44479 ms
Total hot run time: 40109 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4355 4365 4408 4365
q2 267 162 170 162
q3 3521 3518 3498 3498
q4 2382 2377 2356 2356
q5 5715 5729 5744 5729
q6 242 119 119 119
q7 2402 1879 1874 1874
q8 3481 3494 3497 3494
q9 9056 9028 8981 8981
q10 3917 3982 3983 3982
q11 510 393 400 393
q12 778 587 591 587
q13 4295 3575 3580 3575
q14 280 266 259 259
q15 566 518 523 518
q16 503 459 466 459
q17 1859 1841 1852 1841
q18 8685 8196 8392 8196
q19 1701 1720 1750 1720
q20 2242 1950 1946 1946
q21 6491 6161 6162 6161
q22 509 407 421 407
Total cold run time: 63757 ms
Total hot run time: 60622 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847370306
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.99 seconds
stream load tsv: 589 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17224300989 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1846869641
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.96 seconds
stream load tsv: 591 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17212036034 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847101884
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1848319724
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improve](move-memtable) include and check offset when append data [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28159:
URL: https://github.com/apache/doris/pull/28159#issuecomment-1847109589
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org