You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/23 15:38:33 UTC

[GitHub] [lucene] rmuir commented on a diff in pull request #916: Refine contribution guide and pull request template

rmuir commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879605545


##########
CONTRIBUTING.md:
##########
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one responds to your pa
 
 Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request.
 
+You should open a pull request against the `main` branch. It is also recommended to give Lucene maintainers [access](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to your PR branch.

Review Comment:
   Is this "access" step required anymore? Isn't it the default in github these days?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org