You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Masaru Tsuchiyama <m....@gmail.com> on 2013/08/15 10:46:15 UTC

[PATCH] add command line options to mailer.py

Hello

I attach a patch to implement command line options for smtp servers.

[[[
add command line options to mailer.py

* tools/hook-scripts/mailer/mailer.py
  () : import OptionParser.
  (main) : add options to arguments.
  (PipeOutput.__init__) : call cfg.get_mail_command()
                           to get mail command.
  (Messenger.__init__) : call cfg.get_mail_command() and
                         cfg.get_smtp_hostname() to get
                         target.
  (Config.__init__) : add options to arguments and save it.
  (Config.get_mail_command) : get mail command from command line
                              or config.
  (Config.get_smtp_hostname): get smtp hostname from command line
                              or config.
  (Config.get_smtp_username): get smtp username from command line
                              or config.
  (Config.get_smtp_password): get smtp password from command line
                              or config.
  (setup_option_parser) : create instance of OptionParser.
  (usage) : print usage by using OptionParser.
  (): parse command line by using OptionParser.
]]]


-- 
Masaru Tsuchiyama <m....@gmail.com>

Re: [PATCH] add command line options to mailer.py

Posted by Daniel Shahaf <da...@elego.de>.
Masaru Tsuchiyama wrote on Thu, Aug 22, 2013 at 23:10:01 +0900:
> Hello
> 
> Does anybody comment my patch?
> 

FWIW: Saw the patch, it seems like it might be a good idea, but haven't
had time to look into it in more detail.

Re: [PATCH] add command line options to mailer.py

Posted by Masaru Tsuchiyama <m....@gmail.com>.
Hello

Does anybody comment my patch?

-- 
Masaru Tsuchiyama <m....@gmail.com>

Masaru Tsuchiyama wrote:
> Hello
> 
> I attach a patch to implement command line options for smtp servers.
> 
> [[[
> add command line options to mailer.py
> 
> * tools/hook-scripts/mailer/mailer.py
>    () : import OptionParser.
>    (main) : add options to arguments.
>    (PipeOutput.__init__) : call cfg.get_mail_command()
>                             to get mail command.
>    (Messenger.__init__) : call cfg.get_mail_command() and
>                           cfg.get_smtp_hostname() to get
>                           target.
>    (Config.__init__) : add options to arguments and save it.
>    (Config.get_mail_command) : get mail command from command line
>                                or config.
>    (Config.get_smtp_hostname): get smtp hostname from command line
>                                or config.
>    (Config.get_smtp_username): get smtp username from command line
>                                or config.
>    (Config.get_smtp_password): get smtp password from command line
>                                or config.
>    (setup_option_parser) : create instance of OptionParser.
>    (usage) : print usage by using OptionParser.
>    (): parse command line by using OptionParser.
> ]]]
> 
>