You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "efegokdemir (via GitHub)" <gi...@apache.org> on 2026/09/24 05:52:08 UTC
[PR] Fix importdirectory command description layout [accumulo]
efegokdemir opened a new pull request, #6562:
URL: https://github.com/apache/accumulo/pull/6562
## Summary
- Remove the embedded line break from the `importdirectory` command description so the shell formatter keeps the continuation aligned.
- Add a regression test covering the description output.
## Testing
- `mvn -pl shell -am -Dtest=ImportDirectoryCommandTest -DfailIfNoTests=false -DskipFormat test` — passed with Java 21.
- `mvn -pl shell -am -DskipTests -DverifyFormat verify` — passed with Java 21.
- `git diff --check` — passed.
Fixes #6544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix importdirectory command description layout [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #6562:
URL: https://github.com/apache/accumulo/pull/6562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix importdirectory command description layout [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6562:
URL: https://github.com/apache/accumulo/pull/6562#discussion_r4132852382
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ImportDirectoryCommand.java:
##########
@@ -40,7 +40,7 @@ public String description() {
+ " table if the -t option is not provided. The boolean argument determines if accumulo"
+ " sets the time. If the -i ignore option is supplied then no exception will be thrown"
+ " when attempting to import files from an empty source directory. An info log message"
- + " will be displayed indicating the source directory is empty, but no error is thrown.\n"
+ + " will be displayed indicating the source directory is empty, but no error is thrown. "
Review Comment:
```suggestion
+ " will be displayed indicating the source directory is empty, but no error is thrown."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix importdirectory command description layout [accumulo]
Posted by "utafrali (via GitHub)" <gi...@apache.org>.
utafrali commented on code in PR #6562:
URL: https://github.com/apache/accumulo/pull/6562#discussion_r4090397173
##########
shell/src/main/java/org/apache/accumulo/shell/commands/ImportDirectoryCommand.java:
##########
@@ -40,7 +40,7 @@ public String description() {
+ " table if the -t option is not provided. The boolean argument determines if accumulo"
+ " sets the time. If the -i ignore option is supplied then no exception will be thrown"
+ " when attempting to import files from an empty source directory. An info log message"
- + " will be displayed indicating the source directory is empty, but no error is thrown.\n"
+ + " will be displayed indicating the source directory is empty, but no error is thrown. "
+ " Bulk import only takes 2 arguments: <directory> true|false";
}
Review Comment:
The trailing space added here creates a double space when concatenated with the next string literal, which already starts with a space. The result is `"...but no error is thrown. Bulk import only takes 2 arguments..."` (two spaces before "Bulk"). Drop the trailing space since the following string provides the separator:
```java
+ " will be displayed indicating the source directory is empty, but no error is thrown."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org