You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ahmedabu98 (via GitHub)" <gi...@apache.org> on 2024/10/16 20:12:03 UTC
[PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
ahmedabu98 opened a new pull request, #32821:
URL: https://github.com/apache/beam/pull/32821
We were using a workaround because of an issue in ByteBuddy (#32701). This has been fixed so we can now use ByteBuffer normally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2452971259
Reminder, please take a look at this pr: @kennknowles @Abacn @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2462086145
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
R: @damccorm for label build.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2485552072
Reminder, please take a look at this pr: @robertwb @damccorm @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2420564258
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @Abacn for label build.
R: @damondouglas for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2503723652
Reminder, please take a look at this pr: @robertwb @damccorm @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2583282468
On your other PR I basically suggested what you did here. What was the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2437935930
LGTM, however I saw one of the fixes was reverted: https://github.com/apache/beam/issues/32701#issuecomment-2437929579, feel free to merge if get confirm that the original issue indeed fixed and stablelized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2511378406
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @Abacn for label build.
R: @damondouglas for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2486691508
The PR that fixed the original issue was reverted, so we'll wait until a future fix gets in. This change isn't urgent in any way, so will turn it into a draft until then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2437625928
Reminder, please take a look at this pr: @kennknowles @Abacn @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2420562366
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2587384084
I checked with some folks and it should be update-compatible because ByteBuffer gets resolved to `byte[]` for serialization.
The problem is that our current ByteBuddy utils don't fully acknowledge Map parameterized types (more details in issue #32701). This was going to be fixed as a byproduct of this PR #32757, but the PR was later reverted in favor of #32081.
The latter PR doesn't fix this issue. I tried delving in a couple of times recently to fix this again but I couldn't get something substantive quickly enough. I'm not familiar with this realm of Schema inference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2486019657
What is the current status here? It looks like we have a LGTM but checks are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 closed pull request #32821: [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead
URL: https://github.com/apache/beam/pull/32821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2417965849
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2503728314
Waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Managed Iceberg] Cleanup SerializedDataFile; use ByteBuffer instead [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #32821:
URL: https://github.com/apache/beam/pull/32821#issuecomment-2583282656
Update-incompatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org