You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/24 03:16:25 UTC
[GitHub] [rocketmq-mqtt] pingww opened a new pull request, #87: Codecov #80
pingww opened a new pull request, #87:
URL: https://github.com/apache/rocketmq-mqtt/pull/87
add some unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #87: Codecov #80
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #87:
URL: https://github.com/apache/rocketmq-mqtt/pull/87#issuecomment-1107703554
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#87](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (294882c) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/34f499c7249ee82d6c89812aa25ea46dfa1a3224?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34f499c) will **increase** coverage by `2.58%`.
> The diff coverage is `51.85%`.
```diff
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 30.07% 32.66% +2.58%
==========================================
Files 97 98 +1
Lines 4186 4237 +51
Branches 660 671 +11
==========================================
+ Hits 1259 1384 +125
+ Misses 2682 2593 -89
- Partials 245 260 +15
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/rocketmq/mqtt/common/util/SpringUtils.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL21xdHQvY29tbW9uL3V0aWwvU3ByaW5nVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/rocketmq/mqtt/cs/starter/Startup.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zdGFydGVyL1N0YXJ0dXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rocketmq/mqtt/cs/session/loop/SessionLoopImpl.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2xvb3AvU2Vzc2lvbkxvb3BJbXBsLmphdmE=) | `44.85% <50.00%> (+0.37%)` | :arrow_up: |
| [...ocketmq/mqtt/cs/channel/DefaultChannelManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9jaGFubmVsL0RlZmF1bHRDaGFubmVsTWFuYWdlci5qYXZh) | `73.77% <66.66%> (+11.27%)` | :arrow_up: |
| [...tt/ds/upstream/processor/UnSubscribeProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy91cHN0cmVhbS9wcm9jZXNzb3IvVW5TdWJzY3JpYmVQcm9jZXNzb3IuamF2YQ==) | `76.47% <66.66%> (+76.47%)` | :arrow_up: |
| [...mqtt/ds/upstream/processor/SubscribeProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy91cHN0cmVhbS9wcm9jZXNzb3IvU3Vic2NyaWJlUHJvY2Vzc29yLmphdmE=) | `84.21% <70.00%> (+84.21%)` | :arrow_up: |
| [...a/org/apache/rocketmq/mqtt/cs/session/Session.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `39.84% <0.00%> (+2.68%)` | :arrow_up: |
| [...g/apache/rocketmq/mqtt/cs/channel/ChannelInfo.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9jaGFubmVsL0NoYW5uZWxJbmZvLmphdmE=) | `89.89% <0.00%> (+3.03%)` | :arrow_up: |
| [...pache/rocketmq/mqtt/ds/meta/FirstTopicManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tZXRhL0ZpcnN0VG9waWNNYW5hZ2VyLmphdmE=) | `46.57% <0.00%> (+8.21%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e0b5e20...294882c](https://codecov.io/gh/apache/rocketmq-mqtt/pull/87?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] tianliuliu merged pull request #87: Codecov #80
Posted by GitBox <gi...@apache.org>.
tianliuliu merged PR #87:
URL: https://github.com/apache/rocketmq-mqtt/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org