You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/07 14:04:54 UTC
[GitHub] [flink] XComp commented on a change in pull request #17819: [FLINK-15816][k8s] Prevent labels using kubernetes.cluster-id to exceed the limit of 63 characters
XComp commented on a change in pull request #17819:
URL: https://github.com/apache/flink/pull/17819#discussion_r780282356
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java
##########
@@ -220,7 +220,7 @@
.withDescription(
Description.builder()
.text(
- "The cluster-id, which should be no more than 45 characters, is used for identifying a unique Flink cluster. "
+ "The cluster-id, which should be no more than 40 characters, is used for identifying a unique Flink cluster. "
Review comment:
@alpreu I'm just puzzled. Why did we change the limit to `40` initially? The current version of the PR sets the limit to `45` again? I double-checked the code that we didn't miss any other label and couldn't find anything else. But it looks like I'm missing something. I remember that the initial change was valid in terms of the number but we just wanted to make it dynamic. Do you see what I'm missing here, @alpreu ? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org