You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/06 09:24:45 UTC
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #109: [FLINK-27528] Introduce a new configuration option key 'compact.rescale-bucket' for FileStore
JingsongLi commented on code in PR #109:
URL: https://github.com/apache/flink-table-store/pull/109#discussion_r866645769
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java:
##########
@@ -92,6 +92,17 @@ public class FileStoreOptions implements Serializable {
"The default partition name in case the dynamic partition"
+ " column value is null/empty string.");
+ public static final ConfigOption<Boolean> COMPACTION_RESCALE_BUCKET =
+ key("compact.rescale-bucket")
Review Comment:
`compaction.rescale-bucket`?
There are some `compaction.xxx` in `MergeTreeOptions`.
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java:
##########
@@ -92,6 +92,17 @@ public class FileStoreOptions implements Serializable {
"The default partition name in case the dynamic partition"
+ " column value is null/empty string.");
+ public static final ConfigOption<Boolean> COMPACTION_RESCALE_BUCKET =
+ key("compact.rescale-bucket")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Specify the behavior for compaction. Set value to true "
+ + "will lead compaction to reorganize data files "
+ + "according to the bucket number read from catalog meta. "
Review Comment:
`from catalog meta` -> `from table metadata`?
Or `from table schema`?
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/FileStoreOptions.java:
##########
@@ -92,6 +92,17 @@ public class FileStoreOptions implements Serializable {
"The default partition name in case the dynamic partition"
+ " column value is null/empty string.");
+ public static final ConfigOption<Boolean> COMPACTION_RESCALE_BUCKET =
+ key("compact.rescale-bucket")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Specify the behavior for compaction. Set value to true "
+ + "will lead compaction to reorganize data files "
+ + "according to the bucket number read from catalog meta. "
+ + "By default, compaction will use the bucket number read "
Review Comment:
`By default, compaction does not adjust the bucket number of a partition/table.`?
I just think we dont need to expose manifest meta concept to the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org