[GitHub] mistercrunch commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros

[gi...@git.apache.org]

mistercrunch commented on issue #3512: Feature: Making data gaps visible in line charts by inserting zeros
URL: https://github.com/apache/incubator-superset/pull/3512#issuecomment-331497859
 
 
   I like the fact that "insert zeros" as a trigger is much more intuitive than "Resampling". I'm thinking server side on this one. Just because pandas is so simple for this.
   
   See how time grain is fairly loosely defined at the moment? https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs.py#L192
   
   One easy approach would be add a corresponding pandas `freq` to each time grain. Knowing this, it would be easy to resample whenever needed.
   
   "Resampling" came before the "Time-Grain"  concept and is now confusing/obsolete. I feel like we could trigger the pandas resampling based on time grain configuration with a simple checkbox.
   
   In that context, there may be some very few specific use cases where people may want the extra flexibility of resampling with specific fill patterns but I wouldn't be against deprecating the feature.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services