You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/12/03 22:43:22 UTC

Re: Review Request: Slave Restart (Part Deux): Status Update Manager


> On Oct. 30, 2012, 6:06 p.m., Ben Mahler wrote:
> > So all the files will grow unbounded for a given slave run, right?
> > Have you thought about rotation on these files, or do you think their size will be reasonable?

Thats a good point. We haven't thought about how to gc the metadata yet. I will think on it when I do further iterations on the review that includes integration of SUM with the slave (https://reviews.apache.org/r/7655/)


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7212/#review12913
-----------------------------------------------------------


On Oct. 20, 2012, 2:43 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7212/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 2:43 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> added shutdownFramework
> 
> 
> Minor fixes for open
> 
> 
> Ben's comments
> 
> 
> Refactoring SUM
> 
> 
> Bens' comments
> 
> 
> Status Update Manager
> 
> Rebased off latest trunk
> 
> Conflicts:
> 	src/Makefile.am
> 	src/common/protobuf_utils.hpp
> 	src/common/utils.hpp
> 	src/slave/slave.cpp
> 	src/tests/protobuf_io_tests.cpp
> 	src/tests/utils_tests.cpp
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac 
>   src/common/protobuf_utils.hpp 77b300d7c1a02a836100d3365e205889c48ae99a 
>   src/messages/messages.proto 4e0538fe929f9091e5cdd4a1bb017d836df52a3e 
>   src/slave/status_updates_manager.hpp PRE-CREATION 
>   src/slave/status_updates_manager.cpp PRE-CREATION 
>   third_party/libprocess/include/process/timeout.hpp cac996070359a3e7ecdd8077af83c8c4cf9735fd 
> 
> Diff: https://reviews.apache.org/r/7212/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>