[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3489: text areas in search+replace dialog now pretend to be text fields if still small enough.

[GitBox <gi...@apache.org>]

neilcsmith-net commented on a change in pull request #3489:
URL: https://github.com/apache/netbeans/pull/3489#discussion_r790124346



##########
File path: platform/api.search/src/org/netbeans/modules/search/BasicSearchForm.java
##########
@@ -1119,8 +1121,23 @@ private void limitReached() {
         public MultiLineComboBoxEditor() {
             area.setWrapStyleWord(false);
             area.setLineWrap(false);
+
+            // retain standard focus traversal behavior
             area.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERS‌​AL_KEYS, null);
             area.setFocusTraversalKeys(KeyboardFocusManager.BACKWARD_TRAVERS‌​AL_KEYS, null);
+
+            // pretend to be a single line text field if you are small enough
+            area.addKeyListener(new KeyAdapter() {

Review comment:
       I agree with @matthiasblaesing that this seems worse from an accessibility / discoverability point of view.  It may seem trivial, but it's been mentioned twice already, and it's annoyed me about 10 times already, and I know to press `CTRL+ENTER`.  Keyboard control of dialogs is second nature for some people!
   
   I think either make the dialog show at least 2 lines so that multiline behaviour is expected, add some information about `CTRL-ENTER` (and whatever it is on macOS), add another way of accessing multiline, or revert and rethink after NB13.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists