You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/15 15:08:19 UTC
[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
ThanoshanMV opened a new pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056
Fixes #9018
SQL definition of ROLLBACK
Changes proposed in this pull request:
- Modified `TCLStatement.g4` for ROLLBACK definition
- Added keyword `WORK` inside `OracleKeyword.g4`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-762214611
Yes, I would like to work on #9059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-762078110
Hi @ThanoshanMV ，
This draft looks like a good start. I guess you have learned the basic rules of ANTLR. Please go ahead. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-761002682
In this ROLLBACK Backus-Naur Form Syntax:
1. I considered keyword `WORK` as an Oracle Keyword. Is that okay or should we consider it as a Keyword?
2. How can we substitute the placeholders `savepoint` and `string`?
Currently, I substituted `string` as `stringLiterals` imported from `BaseRule`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-762207914
@tristaZero, based on the existing codes on those files, I've done items 5 and 6 specified in #9018 and all tests passed in `SQLParserParameterizedTest`. Can you please check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-761015988
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=h1) Report
> Merging [#9056](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=desc) (0be70ed) into [master](https://codecov.io/gh/apache/shardingsphere/commit/59e45d68e92ebcafd43be737cef5b40add687a87?el=desc) (59e45d6) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9056 +/- ##
=========================================
Coverage 69.71% 69.71%
Complexity 659 659
=========================================
Files 1642 1642
Lines 26532 26532
Branches 4618 4618
=========================================
Hits 18496 18496
Misses 6769 6769
Partials 1267 1267
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=footer). Last update [59e45d6...8404131](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-762143612
Hi @ThanoshanMV ,
It is a simple one, right? I think your PR has a correct definition for `ROLLBACK`, could you consider adding a test for your change? Like item 5, 6 said in #9018.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-762114874
Hi @tristaZero, I substituted placeholder `savepoint` in ROLLBACK definition as `savepointName` imported from `BaseRule.g4`. Are there any changes we need to make for ROLLBACK definition. After these changes, I ran `mvn install` inside `shardingsphere-sql-parser-oracle` directory and build was success.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV edited a comment on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV edited a comment on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-761002682
@tristaZero in this ROLLBACK Backus-Naur Form Syntax:
1. I considered keyword `WORK` as an Oracle Keyword. Is that okay or should we consider it as a Keyword?
2. How can we substitute the placeholders `savepoint` and `string`?
Currently, I substituted `string` as `stringLiterals` imported from `BaseRule`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io edited a comment on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-761015988
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=h1) Report
> Merging [#9056](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=desc) (8404131) into [master](https://codecov.io/gh/apache/shardingsphere/commit/59e45d68e92ebcafd43be737cef5b40add687a87?el=desc) (59e45d6) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9056 +/- ##
============================================
- Coverage 69.71% 69.70% -0.01%
Complexity 659 659
============================================
Files 1642 1642
Lines 26532 26535 +3
Branches 4618 4620 +2
============================================
Hits 18496 18496
- Misses 6769 6770 +1
- Partials 1267 1269 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...end/communication/DatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/9056/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `18.39% <0.00%> (-0.44%)` | `0.00% <0.00%> (ø%)` | |
| [...ore/resultset/ShardingSphereResultSetMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/9056/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvcmVzdWx0c2V0L1NoYXJkaW5nU3BoZXJlUmVzdWx0U2V0TWV0YURhdGEuamF2YQ==) | `8.10% <0.00%> (-0.23%)` | `0.00% <0.00%> (ø%)` | |
| [.../driver/jdbc/adapter/AbstractResultSetAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/9056/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvQWJzdHJhY3RSZXN1bHRTZXRBZGFwdGVyLmphdmE=) | `92.59% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=footer). Last update [59e45d6...8404131](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-762207914
@tristaZero based on the existing codes on those files, I've done items 5 and 6 specified in #9018. Can you please check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-761015988
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=h1) Report
> Merging [#9056](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=desc) (0a0febd) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a0f3b00ba12d00fb7717e76305b1c33c45ebea1f?el=desc) (a0f3b00) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9056 +/- ##
=========================================
Coverage 69.77% 69.77%
Complexity 658 658
=========================================
Files 1640 1640
Lines 26524 26524
Branches 4615 4615
=========================================
Hits 18507 18507
Misses 6751 6751
Partials 1266 1266
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=footer). Last update [a0f3b00...0a0febd](https://codecov.io/gh/apache/shardingsphere/pull/9056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #9056: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #9056:
URL: https://github.com/apache/shardingsphere/pull/9056#issuecomment-762145554
BTW, if you want to have an anther try, #9059 is still a good one for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org