[jira] [Issue Comment Edited] (CAMEL-3906) Consumer and Producer names in JMX

["Claus Ibsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-3906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030855#comment-13030855 ] 

Claus Ibsen edited comment on CAMEL-3906 at 5/9/11 6:51 PM:
------------------------------------------------------------

The problem with this patch is that your hardlock the route label when the MBean gets enlisted. If the route is later stopped, and the processor is adjusted, then the MBean would potential be misleading.

Also the labels can get long and complicated. If you use an aggregator etc.

Also you can potentially have clashes if there are multiple routes with similar routes.
You frankly need the identify hash code.


I have though about adding a /routeX in the MBean key if its part of a route. Then you would have a tree like

+ consumers
\- route1
\- route2

Then its maybe quicker to find the consumer you are looking for.


      was (Author: davsclaus):
    The problem with this patch is that your hardlock the route label when the MBean gets enlisted. If the route is later stopped, and the processor is adjusted, then the MBean would potential be misleading.

Also the labels can get long and complicated. If you use an aggregator etc.

Also you can potentially have clashes if there are multiple routes with similar routes.
You frankly need the identify hash code.


I have though about adding a /routeX in the MBean key if its part of a route. Then you would have a tree like

+ consumers
   + route1
   + route2

Then its maybe quicker to find the consumer you are looking for.

  
> Consumer and Producer names in JMX
> ----------------------------------
>
>                 Key: CAMEL-3906
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3906
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Mitko Kolev
>            Assignee: Ben O'Day
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: CAMEL-3906.patch
>
>
> Currently the consumer and producer names in JMX have a name based on their java instance [1]. Due to this it is not obvious what is the endpoint  of the consumers/producers.
> It can be improved to use name in the JMX tree based on endpoint URI of the consumer/producer endpoints (combined with identityHashcode) to help in the overview to faster spot the desired consumer.
> [1] Copy/paste from the DefaultManagementNamingStrategy
> ...
>    String name = consumer.getClass().getSimpleName();
>         if (ObjectHelper.isEmpty(name)) {
>             name = "Consumer";
>         }
>         buffer.append(KEY_NAME + "=")
>             .append(name)
>             .append("(").append(ObjectHelper.getIdentityHashCode(consumer)).append(")");
> ...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira