You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by anthonycorbacho <gi...@git.apache.org> on 2016/11/29 07:06:13 UTC

[GitHub] zeppelin pull request #1697: [ZEPPELIN-1352] Refactor Notebook repo versioni...

GitHub user anthonycorbacho opened a pull request:

    https://github.com/apache/zeppelin/pull/1697

    [ZEPPELIN-1352] Refactor Notebook repo versioning to return Revision Empty instead of NULL

    ### What is this PR for?
    In Zeppelin notebookRepo, versioning (checkpoint, get, revisionHistory) use to return NULL.
    It will be better to return Empty (Revision or list).
    
    
    ### What type of PR is it?
    [Improvement]
    
    ### What is the Jira issue?
    * [ZEPPELIN-1352](https://issues.apache.org/jira/browse/ZEPPELIN-1352)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anthonycorbacho/incubator-zeppelin ZEPPELIN-1352

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1697.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1697
    
----
commit 989a9953f0f36c366ffb335f8017e566746259f8
Author: Anthony Corbacho <co...@gmail.com>
Date:   2016-11-27T14:09:28Z

    Add to Revision class a static final empty object that will be used to return empty revision instad of null

commit 5127961c45cbf2c1f3985f5427e1b7417150b2be
Author: Anthony Corbacho <co...@gmail.com>
Date:   2016-11-27T14:10:04Z

    Change logic to return Empty (Revision or Collection) instead of null

commit 058b3e778bf371a3378f0cd75213ec8cb42b7831
Author: Anthony Corbacho <co...@gmail.com>
Date:   2016-11-27T14:12:08Z

    Apply return empty revision instead of null in zeppelinhub notebook repo

commit 974c97631b9643e5df828db735ca441dfec04f18
Author: Anthony Corbacho <co...@gmail.com>
Date:   2016-11-28T02:31:10Z

    Fix test in GitNotebookRepo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1697: [ZEPPELIN-1352] Refactor Notebook repo versioning to r...

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1697
  
    normally when doing this kind of changes, need to:
     1.  either override `equals` method or make explicitly static `isEmpty` method that would handle comparison cases. (e.g. `revision1.equals(Revision.EMPTY)` or `Revision.isEmpty(revision1)`)
     2. substitute all instances of that class that previously have been compared with `null`. for example, [here](https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L1400) an instance of it was compared to `null` to see if checkpoint was successful, which wouldn't work now and should be changed.
     
    Generally, this kind of changes would be nice to be reviewed, unless that's hotfix. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1697: [ZEPPELIN-1352] Refactor Notebook repo versioning to r...

Posted by anthonycorbacho <gi...@git.apache.org>.

Github user anthonycorbacho commented on the issue:

    https://github.com/apache/zeppelin/pull/1697
  
    Please review otherwise i am merging it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1697: [ZEPPELIN-1352] Refactor Notebook repo versioni...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1697


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---