You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/15 05:58:02 UTC
[GitHub] [flink] wangyang0918 commented on a change in pull request #10193:
[FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink
submission
wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r346671497
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##########
@@ -149,61 +155,79 @@ public static void setupYarnClassPath(Configuration conf, Map<String, String> ap
String appId,
Path localSrcPath,
Path homedir,
- String relativeTargetPath) throws IOException {
-
- File localFile = new File(localSrcPath.toUri().getPath());
- if (localFile.isDirectory()) {
- throw new IllegalArgumentException("File to copy must not be a directory: " +
- localSrcPath);
- }
+ String relativeTargetPath,
+ @Nullable FileStatus preUploadedFileStatus) throws IOException {
Review comment:
I have moved the `setupLocalResource` without preUploadedFileStatus to another method to avoid huge if-else block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services