[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2574: Build: Support overwrite maven repo by gradle properties

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #2574:
URL: https://github.com/apache/iceberg/pull/2574#discussion_r629445714



##########
File path: deploy.gradle
##########
@@ -113,8 +113,8 @@ subprojects {
         // upload to the releases repository using ./gradlew -Prelease publish
         def apacheSnapshotsRepoUrl = 'https://repository.apache.org/content/repositories/snapshots'
         def apacheReleasesRepoUrl = 'https://repository.apache.org/service/local/staging/deploy/maven2'
-        def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ? project.property('mavenSnapshotsRepo') : "$apacheSnapshotsRepoUrl"
-        def releasesRepoUrl = project.hasProperty('mavenReleasesRepo') ? project.property('mavenReleasesRepo') : "$apacheReleasesRepoUrl"
+        def snapshotsRepoUrl = project.hasProperty('mavenSnapshotsRepo') ? "$mavenSnapshotsRepo" : "$apacheSnapshotsRepoUrl"

Review comment:
       I'm a little lost here, it looks like previously we could set this based on the -PmavenSnapshotsRepo and now we are switching it to a local property? Or does -P handle set the local property as well?
   
   Mostly i'm confused why project.property was not sufficient before




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org