You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Prasad Kashyap (JIRA)" <de...@geronimo.apache.org> on 2006/02/27 20:59:54 UTC

[jira] Created: (GERONIMO-1657) CommandSupport doesn't bubble up the exception. Prints stacktrace.

CommandSupport doesn't bubble up the exception. Prints stacktrace.
------------------------------------------------------------------

         Key: GERONIMO-1657
         URL: http://issues.apache.org/jira/browse/GERONIMO-1657
     Project: Geronimo
        Type: Bug
  Components: deployment  
    Reporter: Prasad Kashyap
 Attachments: Command.patch

C:\Apache\geronimo\modules\deploy-jsr88\src\java\org\apache\geronimo\deployment\plugin\local\

CommandSupport.addWebURLs() prints the stacktrace of an exception. It should be bubbled up to determine the correct status of the deploy.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1657) CommandSupport doesn't bubble up the exception. Prints stacktrace.

Posted by "Prasad Kashyap (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1657?page=all ]

Prasad Kashyap updated GERONIMO-1657:
-------------------------------------

    Attachment: command.patch

This should work. 

> CommandSupport doesn't bubble up the exception. Prints stacktrace.
> ------------------------------------------------------------------
>
>          Key: GERONIMO-1657
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1657
>      Project: Geronimo
>         Type: Bug
>   Components: deployment
>     Reporter: Prasad Kashyap
>  Attachments: Command.patch, command.patch
>
> C:\Apache\geronimo\modules\deploy-jsr88\src\java\org\apache\geronimo\deployment\plugin\local\
> CommandSupport.addWebURLs() prints the stacktrace of an exception. It should be bubbled up to determine the correct status of the deploy.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-1657) CommandSupport doesn't bubble up the exception. Prints stacktrace.

Posted by "Prasad Kashyap (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1657?page=all ]

Prasad Kashyap updated GERONIMO-1657:
-------------------------------------

    Attachment: Command.patch

> CommandSupport doesn't bubble up the exception. Prints stacktrace.
> ------------------------------------------------------------------
>
>          Key: GERONIMO-1657
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1657
>      Project: Geronimo
>         Type: Bug
>   Components: deployment
>     Reporter: Prasad Kashyap
>  Attachments: Command.patch
>
> C:\Apache\geronimo\modules\deploy-jsr88\src\java\org\apache\geronimo\deployment\plugin\local\
> CommandSupport.addWebURLs() prints the stacktrace of an exception. It should be bubbled up to determine the correct status of the deploy.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-1657) CommandSupport doesn't bubble up the exception. Prints stacktrace.

Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
    [ http://issues.apache.org/jira/browse/GERONIMO-1657?page=comments#action_12368870 ] 

Jacek Laskowski commented on GERONIMO-1657:
-------------------------------------------

Upon applying the patch and doing 'maven -o clean default' I got:

java:compile:
<depend closure="false" srcdir="1.4" dump="false" destdir="c:\oss\geronimo\modules\deploy-jsr88/target/classes"></depend>    [echo] Compiling to c:\oss\geronimo\modules\dep
loy-jsr88/target/classes
    [javac] Compiling 24 source files to C:\oss\geronimo\modules\deploy-jsr88\target\classes
    [javac] C:\oss\geronimo\modules\deploy-jsr88\src\java\org\apache\geronimo\deployment\plugin\jmx\JMXDeploymentManager.java:164: unreported exception java.lang.Exception;
 must be caught or declared to be thrown
    [javac]             CommandSupport.addWebURLs(kernel, result);
    [javac]                                      ^
    [javac] 1 error

Would you please get rid of that so I could apply the patch? Please create a patch in the top directory of Geronimo's source tree or in the module itself (modules/deploy-jsr88 in this case).

> CommandSupport doesn't bubble up the exception. Prints stacktrace.
> ------------------------------------------------------------------
>
>          Key: GERONIMO-1657
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1657
>      Project: Geronimo
>         Type: Bug
>   Components: deployment
>     Reporter: Prasad Kashyap
>  Attachments: Command.patch
>
> C:\Apache\geronimo\modules\deploy-jsr88\src\java\org\apache\geronimo\deployment\plugin\local\
> CommandSupport.addWebURLs() prints the stacktrace of an exception. It should be bubbled up to determine the correct status of the deploy.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-1657) CommandSupport doesn't bubble up the exception. Prints stacktrace.

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1657?page=all ]

Vamsavardhana Reddy closed GERONIMO-1657.
-----------------------------------------

    Resolution: Fixed

Modified the patch submitted by Prasad Kashyap to account for the code changes post submission.  Removed printStackTrace and the exception is passed on to the caller.

Fixed in rev 482738 (branches\1.1), rev 482740 (branches\1.2) and rev 482741 (trunk).

> CommandSupport doesn't bubble up the exception. Prints stacktrace.
> ------------------------------------------------------------------
>
>                 Key: GERONIMO-1657
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1657
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 1.1.2, 1.2, 2.0
>            Reporter: Prasad Kashyap
>         Assigned To: Vamsavardhana Reddy
>             Fix For: 1.1.2, 1.2, 2.0
>
>         Attachments: command.patch, Command.patch
>
>
> C:\Apache\geronimo\modules\deploy-jsr88\src\java\org\apache\geronimo\deployment\plugin\local\
> CommandSupport.addWebURLs() prints the stacktrace of an exception. It should be bubbled up to determine the correct status of the deploy.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (GERONIMO-1657) CommandSupport doesn't bubble up the exception. Prints stacktrace.

Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-1657?page=all ]

Vamsavardhana Reddy updated GERONIMO-1657:
------------------------------------------

        Fix Version/s: 1.1.2
                       1.2
                       2.0
    Affects Version/s: 1.1.2
                       1.2
                       2.0
             Assignee: Vamsavardhana Reddy

> CommandSupport doesn't bubble up the exception. Prints stacktrace.
> ------------------------------------------------------------------
>
>                 Key: GERONIMO-1657
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1657
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 1.1.2, 1.2, 2.0
>            Reporter: Prasad Kashyap
>         Assigned To: Vamsavardhana Reddy
>             Fix For: 1.1.2, 1.2, 2.0
>
>         Attachments: command.patch, Command.patch
>
>
> C:\Apache\geronimo\modules\deploy-jsr88\src\java\org\apache\geronimo\deployment\plugin\local\
> CommandSupport.addWebURLs() prints the stacktrace of an exception. It should be bubbled up to determine the correct status of the deploy.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira