You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/31 10:27:38 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
tillrohrmann opened a new pull request #18567:
URL: https://github.com/apache/flink/pull/18567
This commit suppresses the error reporting for ResourceManagerServiceImpl.deregisterApplication
in order to harden the ClusterEntrypointTest.testWorkingDirectoryIsDeletedIfApplicationCompletes.
This is a temporary fix until FLINK-25893 has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18567:
URL: https://github.com/apache/flink/pull/18567#issuecomment-1028748522
Thanks for your review @zentol. I agree that this is not the perfect solution. The PR is intended to fix the current test instabilities that are caused by it. The proper fix will be something else I believe. Once FLINK-25269 is merged, we can make the band-aid more specific. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18567:
URL: https://github.com/apache/flink/pull/18567#discussion_r797639576
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DispatcherResourceManagerComponent.java
##########
@@ -128,7 +128,17 @@ private void registerShutDownFuture() {
public CompletableFuture<Void> stopApplication(
final ApplicationStatus applicationStatus, final @Nullable String diagnostics) {
return internalShutdown(
- () -> resourceManagerService.deregisterApplication(applicationStatus, diagnostics));
+ () ->
+ resourceManagerService
+ .deregisterApplication(applicationStatus, diagnostics)
+ // suppress deregister exception because of FLINK-25893
+ .exceptionally(
+ exception -> {
Review comment:
Can we not make this more specific?
It sounds like we know of 2 specific circumstances where we expect this to fail, but now we are ignoring all errors, even when everything on our side is working properly.
I intended to add a dedicated exception for the RPC endpoint case in https://github.com/zentol/flink/commits/25269.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18567:
URL: https://github.com/apache/flink/pull/18567#discussion_r798342075
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DispatcherResourceManagerComponent.java
##########
@@ -128,7 +128,17 @@ private void registerShutDownFuture() {
public CompletableFuture<Void> stopApplication(
final ApplicationStatus applicationStatus, final @Nullable String diagnostics) {
return internalShutdown(
- () -> resourceManagerService.deregisterApplication(applicationStatus, diagnostics));
+ () ->
+ resourceManagerService
+ .deregisterApplication(applicationStatus, diagnostics)
+ // suppress deregister exception because of FLINK-25893
+ .exceptionally(
+ exception -> {
Review comment:
Once we have FLINK-25269 merged we can make this band aid more specific. At the moment it is simply a stopgap solution.
For the general solution of FLINK-25893, we probably need to rethink the division of responsibilities of registering and deregistering of applications.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #18567: [FLINK-25885] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #18567:
URL: https://github.com/apache/flink/pull/18567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18567:
URL: https://github.com/apache/flink/pull/18567#issuecomment-1025594692
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ba1818d9a60b997a27b971c7a1b8dd348509d2a8 (Mon Jan 31 10:33:38 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-25893).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18567:
URL: https://github.com/apache/flink/pull/18567#issuecomment-1025592946
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ba1818d9a60b997a27b971c7a1b8dd348509d2a8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30505",
"triggerID" : "ba1818d9a60b997a27b971c7a1b8dd348509d2a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba1818d9a60b997a27b971c7a1b8dd348509d2a8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18567:
URL: https://github.com/apache/flink/pull/18567#issuecomment-1025592946
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ba1818d9a60b997a27b971c7a1b8dd348509d2a8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30505",
"triggerID" : "ba1818d9a60b997a27b971c7a1b8dd348509d2a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba1818d9a60b997a27b971c7a1b8dd348509d2a8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30505)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18567:
URL: https://github.com/apache/flink/pull/18567#issuecomment-1025592946
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ba1818d9a60b997a27b971c7a1b8dd348509d2a8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ba1818d9a60b997a27b971c7a1b8dd348509d2a8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ba1818d9a60b997a27b971c7a1b8dd348509d2a8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #18567: [FLINK-25893] Suppress error reporting for ResourceManagerServiceImpl.deregisterApplication
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #18567:
URL: https://github.com/apache/flink/pull/18567#issuecomment-1028969201
Thanks for the review @zentol. Merging this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org