[GitHub] [camel-k] astefanutti commented on a change in pull request #2328: Extra repositories

[GitBox <gi...@apache.org>]

astefanutti commented on a change in pull request #2328:
URL: https://github.com/apache/camel-k/pull/2328#discussion_r642281728



##########
File path: pkg/apis/camel/v1/common_types.go
##########
@@ -93,8 +93,9 @@ type MavenSpec struct {
 	// A JKS formatted keystore is automatically created to store the CA certificate(s),
 	// and configured to be used as a trusted certificate(s) by the Maven commands.
 	// Note that the root CA certificates are also imported into the created keystore.
-	CASecret *corev1.SecretKeySelector `json:"caSecret,omitempty"`
-	Timeout  *metav1.Duration          `json:"timeout,omitempty"`
+	CASecret     *corev1.SecretKeySelector `json:"caSecret,omitempty"`
+	Timeout      *metav1.Duration          `json:"timeout,omitempty"`
+	Repositories []string                  `json:"repositories,omitempty"`

Review comment:
       Would it be possible to use the _structured_ repository definition in the API? The string representation is rather a CLI convenience, and it might be better avoiding leaking it into the API.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org