You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/09 20:14:00 UTC
[jira] [Commented] (AIRFLOW-6206) Use a consistent `aws_` prefix
for AWS contrib modules
[ https://issues.apache.org/jira/browse/AIRFLOW-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991925#comment-16991925 ]
ASF GitHub Bot commented on AIRFLOW-6206:
-----------------------------------------
darrenleeweber commented on pull request #6764: [AIRFLOW-6206] Use "aws_" prefix for aws_batch_operator.py module
URL: https://github.com/apache/airflow/pull/6764
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow Jira]
- https://issues.apache.org/jira/browse/AIRFLOW-6206
### Description
- [x] Use a consistent "aws_" prefix for contrib/operators
before:
```
$ ls -1 airflow/contrib/operators/aws*
airflow/contrib/operators/aws_athena_operator.py
airflow/contrib/operators/awsbatch_operator.py
airflow/contrib/operators/aws_sqs_publish_operator.py
```
after this PR:
```
$ ls -1 airflow/contrib/operators/aws*
airflow/contrib/operators/aws_athena_operator.py
airflow/contrib/operators/aws_batch_operator.py
airflow/contrib/operators/aws_sqs_publish_operator.py
```
### Tests
- [x] My PR does not change existing test success:
```
$ pytest tests/contrib/operators/test_awsbatch_operator.py
============================================================================ test session starts ============================================================================
platform linux -- Python 3.6.7, pytest-5.3.1, py-1.8.0, pluggy-0.13.1 -- /opt/conda/envs/airflow/bin/python
cachedir: .pytest_cache
rootdir: /home/dlweber/src/airflow/tests, inifile: pytest.ini
plugins: cov-2.8.1, requests-mock-1.7.0, flaky-3.6.1
collected 10 items
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_check_success_task_not_raises PASSED [ 10%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_check_success_tasks_raises PASSED [ 20%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_check_success_tasks_raises_failed PASSED [ 30%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_check_success_tasks_raises_multiple PASSED [ 40%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_check_success_tasks_raises_pending PASSED [ 50%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_execute_with_failures PASSED [ 60%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_execute_without_failures PASSED [ 70%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_init PASSED [ 80%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_template_fields_overrides PASSED [ 90%]
tests/contrib/operators/test_awsbatch_operator.py::TestAWSBatchOperator::test_wait_end_tasks PASSED [100%]
============================================================================ 10 passed in 0.11s =============================================================================
```
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- existing documentation is patched to use the revised module name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Use a consistent `aws_` prefix for AWS contrib modules
> ------------------------------------------------------
>
> Key: AIRFLOW-6206
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6206
> Project: Apache Airflow
> Issue Type: Improvement
> Components: aws
> Affects Versions: 1.10.6
> Reporter: Darren Weber
> Assignee: Darren Weber
> Priority: Minor
>
> Use common "aws_" prefix for aws_batch_operator.py module (and other AWS modules).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)