You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/11 12:14:44 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5553: minor: improve sqllogictest docs
alamb opened a new pull request, #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553
# Which issue does this PR close?
N/A
# Rationale for this change
I keep pointing / suggesting people use these tests so I want to make it as easy as possible to use
# What changes are included in this PR?
Make a cookbook section to put all the most commonly used commands at the beginning
# Are these changes tested?
N/A
# Are there any user-facing changes?
Docs
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5553: minor: improve sqllogictest docs
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553#discussion_r1133088625
##########
datafusion/core/tests/sqllogictests/README.md:
##########
@@ -19,25 +19,41 @@
#### Overview
-This is the Datafusion implementation of [sqllogictest](https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki). We use [sqllogictest-rs](https://github.com/risinglightdb/sqllogictest-rs) as a parser/runner of `.slt` files in `test_files`.
+This is the Datafusion implementation of [sqllogictest](https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki). We use [sqllogictest-rs](https://github.com/risinglightdb/sqllogictest-rs) as a parser/runner of `.slt` files in [`test_files`](test_files).
-#### Running tests: Validation Mode
+#### Running tests: TLDR Examples
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #5553: minor: improve sqllogictest docs
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5553: minor: improve sqllogictest docs
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553#issuecomment-1464899289
FYI @melgenek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5553: minor: improve sqllogictest docs
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553#issuecomment-1464920466
Benchmark runs are scheduled for baseline = aaa4e1496ba89daa03de47dc1feed7d7e57f62a8 and contender = dd98aabdaebcfc30ec4c370be93f6663de50e02f. dd98aabdaebcfc30ec4c370be93f6663de50e02f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/108fe5ded9fa481595c713bbbc0513e3...5d3ba2775b694c6e927b7d658c33c338/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/03d09d76cb1d47f2810f827c518ec9bc...d3d73d4c3f8f4e55bf323cd557ce9766/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/28cb16989c2f4b6496a6a116cd473f18...5dfc543fc15146458d0bafa006df1714/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a50eb8c37840442baf366a434da84f62...1e91e3b571074d39b0c51277c75c7f05/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org