[PR] [feat] support refresh the config of syncer without redeploy servicec… [servicecomb-service-center]

["tornado-ssy (via GitHub)" <gi...@apache.org>]

tornado-ssy opened a new pull request, #1467:
URL: https://github.com/apache/servicecomb-service-center/pull/1467

   …omb-center
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    - [ ] Never comment source code, delete it.
    - [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [feat] support refresh the config of syncer without redeploy servicec… [servicecomb-service-center]

["little-cui (via GitHub)" <gi...@apache.org>]

little-cui commented on code in PR #1467:
URL: https://github.com/apache/servicecomb-service-center/pull/1467#discussion_r1562223866


##########
syncer/config/config.go:
##########
@@ -44,28 +46,32 @@ type Peer struct {
 	Mode      []string `yaml:"mode"`
 }
 
-func Init() error {
-	err := archaius.AddFile(filepath.Join(util.GetAppRoot(), "conf", "syncer.yaml"))
+func Init() (error, bool) {
+	err := archaius.AddFile(filepath.Join(util.GetAppRoot(), "conf", "syncer", "syncer.yaml"))
 	if err != nil {
 		log.Warn(fmt.Sprintf("can not add syncer config file source, error: %s", err))
-		return err
+		return err, false
 	}
 
-	err = Reload()
+	err, isRefresh := Reload()

Review Comment:
   不需要定期刷新，go-chassis集成了动态配置框架go-archaius，使用方式如下
   endpoint = archaius.GetString("syncer.endpoint", "")



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org