You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/15 04:56:02 UTC

[GitHub] [superset] john-bodley opened a new pull request #16266: chore(pylint): Reenable raise-missing-from check

john-bodley opened a new pull request #16266:
URL: https://github.com/apache/superset/pull/16266


   ### SUMMARY
   
   Re-enabling the Pylint `raise-missing-from` check.
   
   Note one thing which was somewhat concerning whilst updating the code was a common theme of repeated code logic, i.e., there are multiple [`validate_json`](https://github.com/apache/superset/search?q=%22def+validate_json%22) method with identical (or near identical logic). Thankfully there is a `duplicate-code` Pylint check (currently disabled) which can prevent this from occurring in the future, however I sense there needs to be a collective effort to rectify the issue in the current code.
   
   ### TESTING INSTRUCTIONS
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: https://github.com/apache/superset/issues/9953
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #16266: chore(pylint): Reenable raise-missing-from check

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16266:
URL: https://github.com/apache/superset/pull/16266#issuecomment-898996883


   # [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16266](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (460435d) into [master](https://codecov.io/gh/apache/superset/commit/3709131089ba866de534c0f3765a8e1123df0204?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3709131) will **decrease** coverage by `0.22%`.
   > The diff coverage is `46.99%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/16266/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #16266      +/-   ##
   ==========================================
   - Coverage   76.70%   76.48%   -0.23%     
   ==========================================
     Files         997      997              
     Lines       53240    53240              
     Branches     6774     6774              
   ==========================================
   - Hits        40838    40720     -118     
   - Misses      12172    12290     +118     
     Partials      230      230              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `81.56% <46.99%> (+0.04%)` | :arrow_up: |
   | postgres | `81.55% <46.99%> (-0.05%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.67% <46.99%> (-0.43%)` | :arrow_down: |
   | sqlite | `81.23% <44.80%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvY3JlYXRlLnB5) | `90.32% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvZGVsZXRlLnB5) | `89.65% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvdXBkYXRlLnB5) | `91.89% <0.00%> (ø)` | |
   | ... and [78 more](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3709131...460435d](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley merged pull request #16266: chore(pylint): Reenable raise-missing-from check

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #16266:
URL: https://github.com/apache/superset/pull/16266


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #16266: chore(pylint): Reenable raise-missing-from check

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16266:
URL: https://github.com/apache/superset/pull/16266#issuecomment-898996883


   # [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16266](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (460435d) into [master](https://codecov.io/gh/apache/superset/commit/3709131089ba866de534c0f3765a8e1123df0204?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3709131) will **decrease** coverage by `0.22%`.
   > The diff coverage is `46.99%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/16266/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #16266      +/-   ##
   ==========================================
   - Coverage   76.70%   76.48%   -0.23%     
   ==========================================
     Files         997      997              
     Lines       53240    53240              
     Branches     6774     6774              
   ==========================================
   - Hits        40838    40720     -118     
   - Misses      12172    12290     +118     
     Partials      230      230              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `81.56% <46.99%> (+0.04%)` | :arrow_up: |
   | postgres | `81.55% <46.99%> (-0.04%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.67% <46.99%> (-0.43%)` | :arrow_down: |
   | sqlite | `81.23% <44.80%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvY3JlYXRlLnB5) | `90.32% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvZGVsZXRlLnB5) | `89.65% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvdXBkYXRlLnB5) | `91.89% <0.00%> (ø)` | |
   | ... and [78 more](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3709131...460435d](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #16266: chore(pylint): Reenable raise-missing-from check

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16266:
URL: https://github.com/apache/superset/pull/16266#issuecomment-898996883


   # [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16266](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8cce8b2) into [master](https://codecov.io/gh/apache/superset/commit/36bc7b0b8055b7ccdfe06033e418363b41e56c66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36bc7b0) will **decrease** coverage by `0.07%`.
   > The diff coverage is `46.44%`.
   
   > :exclamation: Current head 8cce8b2 differs from pull request most recent head 6ccca2f. Consider uploading reports for the commit 6ccca2f to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/16266/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #16266      +/-   ##
   ==========================================
   - Coverage   76.64%   76.56%   -0.08%     
   ==========================================
     Files         997      997              
     Lines       53246    53246              
     Branches     6777     6777              
   ==========================================
   - Hits        40808    40770      -38     
   - Misses      12208    12246      +38     
     Partials      230      230              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `81.35% <46.44%> (+0.04%)` | :arrow_up: |
   | mysql | `?` | |
   | postgres | `?` | |
   | python | `81.85% <46.44%> (-0.14%)` | :arrow_down: |
   | sqlite | `81.23% <44.80%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvY3JlYXRlLnB5) | `90.32% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvZGVsZXRlLnB5) | `89.65% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvdXBkYXRlLnB5) | `91.89% <0.00%> (ø)` | |
   | ... and [79 more](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [36bc7b0...6ccca2f](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #16266: chore(pylint): Reenable raise-missing-from check

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16266:
URL: https://github.com/apache/superset/pull/16266#issuecomment-898996883


   # [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#16266](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (460435d) into [master](https://codecov.io/gh/apache/superset/commit/3709131089ba866de534c0f3765a8e1123df0204?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3709131) will **decrease** coverage by `0.07%`.
   > The diff coverage is `47.54%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/16266/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #16266      +/-   ##
   ==========================================
   - Coverage   76.70%   76.62%   -0.08%     
   ==========================================
     Files         997      997              
     Lines       53240    53240              
     Branches     6774     6774              
   ==========================================
   - Hits        40838    40797      -41     
   - Misses      12172    12213      +41     
     Partials      230      230              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `81.31% <46.44%> (ø)` | |
   | mysql | `81.56% <46.99%> (+0.04%)` | :arrow_up: |
   | postgres | `81.55% <46.99%> (-0.05%)` | :arrow_down: |
   | presto | `?` | |
   | python | `81.95% <47.54%> (-0.15%)` | :arrow_down: |
   | sqlite | `81.23% <44.80%> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...otation\_layers/annotations/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `88.46% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvY3JlYXRlLnB5) | `86.66% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvZGVsZXRlLnB5) | `85.18% <0.00%> (ø)` | |
   | [...t/annotation\_layers/annotations/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvY29tbWFuZHMvdXBkYXRlLnB5) | `88.23% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/dao.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvZGFvLnB5) | `85.18% <0.00%> (ø)` | |
   | [superset/annotation\_layers/annotations/schemas.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvc2NoZW1hcy5weQ==) | `86.66% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/bulk\_delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvYnVsa19kZWxldGUucHk=) | `85.71% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/create.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvY3JlYXRlLnB5) | `90.32% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/delete.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvZGVsZXRlLnB5) | `89.65% <0.00%> (ø)` | |
   | [superset/annotation\_layers/commands/update.py](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvY29tbWFuZHMvdXBkYXRlLnB5) | `91.89% <0.00%> (ø)` | |
   | ... and [73 more](https://codecov.io/gh/apache/superset/pull/16266/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3709131...460435d](https://codecov.io/gh/apache/superset/pull/16266?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org