You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/14 08:44:00 UTC
[jira] [Commented] (AVRO-3639) [Rust] Derive implementation for Eq where possible
[ https://issues.apache.org/jira/browse/AVRO-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617566#comment-17617566 ]
ASF subversion and git services commented on AVRO-3639:
-------------------------------------------------------
Commit 1027938c46ed3ae07ac7c23ecd0764bd357df23f in avro's branch refs/heads/master from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=1027938c4 ]
AVRO-3639: Add fleet.toml and .cargo/config.toml to gitignore
We don't use .cargo/config.toml for anything custom for now!
Using Jetbrains Fleet generates such files with its custom stuff inside.
If we ever need to add custom and general Cargo config then we
(developers) should stop using Fleet.
Signed-off-by: Martin Tzvetanov Grigorov <mg...@apache.org>
> [Rust] Derive implementation for Eq where possible
> --------------------------------------------------
>
> Key: AVRO-3639
> URL: https://issues.apache.org/jira/browse/AVRO-3639
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Minor
>
> Rust nightly clippy reports errors like:
> {code:java}
> error: you are deriving `PartialEq` and can implement `Eq`
> --> avro_derive/tests/derive.rs:1081:64
> |
> 1081 | #[derive(Debug, Serialize, Deserialize, AvroSchema, Clone, PartialEq)]
> | ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
> {code}
>
> Most of those errors are in test code but anyway it would be good to fix them!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)