You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Denes Arvay <de...@cloudera.com> on 2017/06/08 13:32:45 UTC

Re: Review Request 53056: FLUME-2945: Bump java target version to 1.8

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53056/#review177301
-----------------------------------------------------------


Ship it!




LGTM, +1

- Denes Arvay


On Oct. 24, 2016, 1:27 p.m., Lior Zeno wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53056/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2016, 1:27 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> We should move to Java 8 as a minimum requirement.
> 
> 1. Java 7 is EOL'ed http://www.oracle.com/technetwork/java/eol-135779.html.
> 2. Many projects are adopting java 8 as a minimum requirement, for instance:
> 
>     * Solr 6: https://issues.apache.org/jira/browse/LUCENE-6722
>     * Hbase 2: https://issues.apache.org/jira/browse/HBASE-15624
>     * elasticsearch 5: https://www.elastic.co/guide/en/elasticsearch/reference/master/setup.html
> 
> 
> Diffs
> -----
> 
>   .travis.yml befc2c9 
>   DEVNOTES 83cdf89 
>   README.md 9ebb2a3 
>   conf/flume-env.sh.template 07182ca 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst cd76bb3 
>   flume-ng-sources/flume-taildir-source/pom.xml 96c2468 
>   pom.xml f62c99a 
> 
> 
> Diff: https://reviews.apache.org/r/53056/diff/6/
> 
> 
> Testing
> -------
> 
> The attached patch was tested on Ubuntu 16.04 with openjdk version "1.8.0_91".
> All unit tests, except for the known flaky ones, successfully passed.
> 
> 
> Thanks,
> 
> Lior Zeno
> 
>