You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/08 12:23:24 UTC
[GitHub] [inlong] gong opened a new pull request, #5410: [INLONG-5409][Manager] Fix json serialization for class BaseSortConf
gong opened a new pull request, #5410:
URL: https://github.com/apache/inlong/pull/5410
### Prepare a Pull Request
- [INLONG-5409][Manager] Fix json serialization for class BaseSortConf
- Fixes #5409
### Motivation
Fix json serialization for class BaseSortConf
### Modifications
* Remove `sortType` field for BaseSortConf
* Add `getType` method for FlinkSortConf and UserDefinedSortConf
* Remove `type` field for FlinkSortConf and UserDefinedSortConf
* Add UT for BaseSortConf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5410: [INLONG-5409][Manager] Fix json serialization for class BaseSortConf
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5410:
URL: https://github.com/apache/inlong/pull/5410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #5410: [INLONG-5409][Manager] Fix json serialization for class BaseSortConf
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5410:
URL: https://github.com/apache/inlong/pull/5410#discussion_r940837205
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/BaseSortConf.java:
##########
@@ -29,8 +29,6 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, visible = true, property = "sortType")
public abstract class BaseSortConf {
- public String sortType;
Review Comment:
It don't need declare `sortType` field. Annotation will generate sortType data when serialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5410: [INLONG-5409][Manager] Fix json serialization for class BaseSortConf
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5410:
URL: https://github.com/apache/inlong/pull/5410#discussion_r940384501
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/BaseSortConf.java:
##########
@@ -29,8 +29,6 @@
@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, visible = true, property = "sortType")
public abstract class BaseSortConf {
- public String sortType;
Review Comment:
This field should not be removed, because it was used by `JsonTypeInfo`.
Suggests set its value in each subclass's constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org